Make reuse trigger cli args public#3402
Merged
fibonacci1729 merged 1 commit intomainfrom Feb 17, 2026
Merged
Conversation
Signed-off-by: Brian Hardock <brian.hardock@fermyon.com>
kate-goldenring
approved these changes
Feb 17, 2026
Contributor
kate-goldenring
left a comment
kate-goldenring
left a comment
There was a problem hiding this comment.
@fibonacci1729 thank you. I am concerned we could run into this again if another field is added to CliArgs. One way to avoid this is by creating a public constructor -- it feels a little strange for other executors to be consuming a CliArgs struct, but this may just be a naming nit.
itowlson
approved these changes
Feb 17, 2026
Contributor
@fibonacci1729 what were your thoughts on this point. Its a non-blocking comment but potentially an enhancement |
Collaborator
Author
|
Sorry @kate-goldenring I closed this tab earlier before hitting comment. 🤦 I agree that a constructor would prevent this in a future addition to the struct. Technically it's a breaking change to add any non-pub fields to |
kate-goldenring
added a commit
to kate-goldenring/containerd-shim-spin
that referenced
this pull request
Feb 18, 2026
- Bumps the dependencies to use a git reference just past Spin 3.6 to contain these two patches to Spin that enable continued consumption of the Spin crates by the shim: spinframework/spin#3402 and spinframework/spin#3403 - Updates the shim to support packages pushed with wkg, a change introduced in Spin here spinframework/spin#3361 - Adds a wkg integration test - Adds extensive unit tests for the Source struct (with the help of Claude). These tests point out some gaps in the implementation to better handle edge cases (most are edge cases are ignored) Signed-off-by: Kate Goldenring <kate.goldenring@gmail.com>
kate-goldenring
added a commit
to kate-goldenring/containerd-shim-spin
that referenced
this pull request
Feb 18, 2026
- Bumps the dependencies to use a git reference just past Spin 3.6 to contain these two patches to Spin that enable continued consumption of the Spin crates by the shim: spinframework/spin#3402 and spinframework/spin#3403 - Updates the shim to support packages pushed with wkg, a change introduced in Spin here spinframework/spin#3361 - Adds a wkg integration test - Adds extensive unit tests for the Source struct (with the help of Claude). These tests point out some gaps in the implementation to better handle edge cases (most are edge cases are ignored) Signed-off-by: Kate Goldenring <kate.goldenring@gmail.com>
kate-goldenring
added a commit
to kate-goldenring/containerd-shim-spin
that referenced
this pull request
Feb 18, 2026
- Bumps the dependencies to use a git reference just past Spin 3.6 to contain these two patches to Spin that enable continued consumption of the Spin crates by the shim: spinframework/spin#3402 and spinframework/spin#3403 - Updates the shim to support packages pushed with wkg, a change introduced in Spin here spinframework/spin#3361 - Adds a wkg integration test - Adds extensive unit tests for the Source struct (with the help of Claude). These tests point out some gaps in the implementation to better handle edge cases (most are edge cases are ignored) Signed-off-by: Kate Goldenring <kate.goldenring@gmail.com>
kate-goldenring
added a commit
to kate-goldenring/containerd-shim-spin
that referenced
this pull request
Feb 18, 2026
- Bumps the dependencies to use a git reference just past Spin 3.6 to contain these two patches to Spin that enable continued consumption of the Spin crates by the shim: spinframework/spin#3402 and spinframework/spin#3403 - Updates the shim to support packages pushed with wkg, a change introduced in Spin here spinframework/spin#3361 - Adds a wkg integration test - Adds extensive unit tests for the Source struct (with the help of Claude). These tests point out some gaps in the implementation to better handle edge cases (most are edge cases are ignored) Signed-off-by: Kate Goldenring <kate.goldenring@gmail.com>
kate-goldenring
added a commit
to kate-goldenring/containerd-shim-spin
that referenced
this pull request
Feb 19, 2026
- Bumps the dependencies to use a git reference just past Spin 3.6 to contain these two patches to Spin that enable continued consumption of the Spin crates by the shim: spinframework/spin#3402 and spinframework/spin#3403 - Updates the shim to support packages pushed with wkg, a change introduced in Spin here spinframework/spin#3361 - Adds a wkg integration test - Adds extensive unit tests for the Source struct (with the help of Claude). These tests point out some gaps in the implementation to better handle edge cases (most are edge cases are ignored) Signed-off-by: Kate Goldenring <kate.goldenring@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downstream crates that might want to expose instance reuse arguments to operators currently can't because these fields are private. This PR makes the fields of
CliArgspublic as well as theRangetype.