Adding storage specification for Machine Allocation#17
Open
CallMeCCLemon wants to merge 1 commit intospectrocloud:mainfrom
Open
Adding storage specification for Machine Allocation#17CallMeCCLemon wants to merge 1 commit intospectrocloud:mainfrom
CallMeCCLemon wants to merge 1 commit intospectrocloud:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes
This change follows standard paradigms in the
machine.gofile to specify additional parameters to pass to themachine.Allocatefunction for storage labels. If a VM is being provisioned automatically via ClusterAPI, it will always default to 8GB of storage and if a machine's image results in a larger storage requirement, it will fail to provision the VM automatically.Testing
This change should pass all unit & integration tests (they cannot run outside of the Spectro Cloud test environments it seems due to hard-coded dependencies and MaaS infrastructure configuration). The change has a low-risk of causing impact as this field should not be used by existing clients.