Adding storage spec to Maas machine template#92
Open
CallMeCCLemon wants to merge 2 commits intospectrocloud:mainfrom
Open
Adding storage spec to Maas machine template#92CallMeCCLemon wants to merge 2 commits intospectrocloud:mainfrom
CallMeCCLemon wants to merge 2 commits intospectrocloud:mainfrom
Conversation
Author
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes
This PR is dependent on Maas-client-go PR #17.
This change adds a storage field to the MaasMachineTemplate to allow a user to specify storage requirements for machine selection. This is specifically necessary in cases where an image would exceed the default 8GB of storage space for a newly composed Virtual Machine. The specification will allow for custom VM storage allocations during the provisioning process.
Testing
All tests are passing. No major functionality changes.