Skip to content

SWSV016-01 Weather Sealing, Commercial - new measure#96

Open
simularis wants to merge 18 commits intosound-data:mainfrom
simularis:Leakage-Commercial
Open

SWSV016-01 Weather Sealing, Commercial - new measure#96
simularis wants to merge 18 commits intosound-data:mainfrom
simularis:Leakage-Commercial

Conversation

@simularis
Copy link
Copy Markdown
Contributor

@simularis simularis commented Dec 6, 2024

Pull Request (PR) Description

  • Created new measure folder "commercial measures/SWSV016-01 Weather Sealing"
  • Used infil_area parameter to vary infiltration to two distinct levels above default (15% and 30%)
  • Applied measure to all commercial building types and 5 HVAC types (using TRC HVAC inputs)

Main contributor: @Alyza-K
QC: @simularis

PR Author

  • Make sure the PR branch is up to date with main branch at the time of the PR submission
  • Craft a succinct title that effectively encapsulates the essence of the pull request, providing a general overview of the proposed changes.
  • Label the PR with at least one of the following: New Measure, Bug, or Feature.
  • Provide a concise description of the measure, bug, or feature. Submit one PR per measure.
  • For a new measure, attach a workbook named DEER_EnergyPlus_Modelkit_Measure_list_working.xlsx, containing only rows used for post-processing the measure.
  • N/A Add comments in the code when necessary to facilitate the review process.
  • N/A Add a comment before the added code, including the author's full name, company, and specifying if it's a bug fix, new measure, or feature.
  • For a new feature or bug, demonstrate the impact on energy consumption for selected cases with justification using plots and descriptions.
  • For a new measure, add a summary table showing total energy consumption per simulated case.

PR Reviewer

  • Conduct a thorough code review.
  • If the branch is behind the main, merge the branch locally to check for potential conflicts.
  • If a bug, locally reproduce it and compare energy consumptions before and after.
  • Explore creative ways to stress-test the code.
  • Locally check the error file and other outputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant