Skip to content

Added leakage residential measure#9

Merged
simularis merged 3 commits intosimularis:leakage-residentialfrom
Alyza-K:leakage-residential
Jan 31, 2025
Merged

Added leakage residential measure#9
simularis merged 3 commits intosimularis:leakage-residentialfrom
Alyza-K:leakage-residential

Conversation

@Alyza-K
Copy link
Copy Markdown

@Alyza-K Alyza-K commented Dec 3, 2024

Pull Request (PR) Description

NOTE: SUBMIT A PLAN TO DEER SUPPORT PRIOR TO WORKING ON CODE FOR A MEASURE, FEATURE, OR BUG TO BE CONNECTED WITH OTHERS WORKING ON THE SAME ISSUE OR TO RECEIVE FEEDBACK ON YOUR PROPOSED METHOD

DEER Support Email: DeerSupport@dnv.com

PR Author

  • Make sure the PR branch is up to date with main branch at the time of the PR submission
  • Craft a succinct title that effectively encapsulates the essence of the pull request, providing a general overview of the proposed changes.
  • Label the PR with at least one of the following: New Measure, Bug, or Feature.
  • Provide a concise description of the measure, bug, or feature. Submit one PR per measure.
  • For a new measure, attach a workbook named DEER_EnergyPlus_Modelkit_Measure_list_working.xlsx, containing only rows used for post-processing the measure.
  • Add comments in the code when necessary to facilitate the review process.
  • Add a comment before the added code, including the author's full name, company, and specifying if it's a bug fix, new measure, or feature.
  • For a new feature or bug, demonstrate the impact on energy consumption for selected cases with justification using plots and descriptions.
  • For a new measure, add a summary table showing total energy consumption per simulated case.

PR Reviewer

  • Conduct a thorough code review.
  • If the branch is behind the main, merge the branch locally to check for potential conflicts.
  • If a bug, locally reproduce it and compare energy consumptions before and after.
  • Explore creative ways to stress-test the code.
  • Locally check the error file and other outputs.

@simularis simularis changed the base branch from main to leakage-residential January 25, 2025 00:32
@simularis
Copy link
Copy Markdown
Owner

@Alyza-K please

  • Write a brief description of the pull request similar to example here: SWSV016-01 Weather Sealing, Commercial - new measure sound-data/DEER-Prototypes-EnergyPlus#96 (just the bullet points at the beginning)
  • There were some changes merged into sound-data main branch on December 7, 2024. We will need to merge those changes into our branch, but first we should review the changes to determine:
    • Did any of their changes impact infiltration? (No. I reviewed the changes and although there is close overlap with the infiltration parameter, their edits did not change the default value or require any changes to our cases files.)
    • Did any other changes impact the building in a way that might change energy usage or savings? (Specifically, in some templates, the zone name input to ZoneInfiltration:DesignFlowRate object was changed. We should determine if the zone name is connected to any other object in the model, i.e., does the change represent a bug fix or an unused label for convenience?)
  • Clone the repository into a new folder (preserve the folder with your simulations) and merge changes from sound-data main branch into our branch. If the merge gives errors, let me know.

@simularis
Copy link
Copy Markdown
Owner

Pull Request Description

  • Created new measure folder "commercial measures/SWSV015-01 Weather Sealing" within residential measures
  • Used infiltration_ACH parameter to vary infiltration to two distinct levels above default (15% and 30%) for 3 different vintages (pre78, 78-92, and 93)
  • Applied measure to 4 residential building types (DMo, MFm, SFm_1975, and SFm_1985)
  • 4 HVAC types were considered per residential building type (DXGF, DXHP, NCEH, and NCGF)
  • For SFm building types and vintages both 1 and 2 story cases were considered

@simularis
Copy link
Copy Markdown
Owner

Based on a sample of building models, the December 7, 2024 commits to main branch did not have any impact on model usage. See sound-data#53

Attached:
SWSV015-residential-comparison.xlsx

@simularis simularis merged commit 3b14196 into simularis:leakage-residential Jan 31, 2025
simularis pushed a commit that referenced this pull request Feb 11, 2025
Create a python package requirements file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants