Skip to content

SWSV015-01 Weather Sealing, Residential - new measure#99

Open
simularis wants to merge 4 commits intosound-data:mainfrom
simularis:leakage-residential
Open

SWSV015-01 Weather Sealing, Residential - new measure#99
simularis wants to merge 4 commits intosound-data:mainfrom
simularis:leakage-residential

Conversation

@simularis
Copy link
Copy Markdown
Contributor

@simularis simularis commented Jan 31, 2025

Pull Request (PR) Description

  • Created new measure folder "residential measures/SWSV015-01 Weather Sealing" within residential measures
  • Used infiltration_ACH parameter to vary infiltration to two distinct levels above default (15% and 30%) for 3 different vintages (pre78, 78-92, and 93)
  • Applied measure to 4 residential building types (DMo, MFm, SFm_1975, and SFm_1985)
  • 4 HVAC types were considered per residential building type (DXGF, DXHP, NCEH, and NCGF)
  • For SFm building types and vintages both 1 and 2 story cases were considered

Note that SFm post-processing was applied in Excel to consolidate 1-story and 2-story variants into weighted average.

Internal QC documented at simularis#9.

Main contributor: @Alyza-K
QC: @simularis

PR Author

  • Make sure the PR branch is up to date with main branch at the time of the PR submission
  • Craft a succinct title that effectively encapsulates the essence of the pull request, providing a general overview of the proposed changes.
  • Label the PR with at least one of the following: New Measure, Bug, or Feature.
  • Provide a concise description of the measure, bug, or feature. Submit one PR per measure.
  • For a new measure, attach a workbook named DEER_EnergyPlus_Modelkit_Measure_list_working.xlsx, containing only rows used for post-processing the measure.
  • Add comments in the code when necessary to facilitate the review process.
  • Add a comment before the added code, including the author's full name, company, and specifying if it's a bug fix, new measure, or feature.
  • For a new feature or bug, demonstrate the impact on energy consumption for selected cases with justification using plots and descriptions. see attached
  • For a new measure, add a summary table showing total energy consumption per simulated case. see attached

PR Reviewer

  • Conduct a thorough code review.
  • If the branch is behind the main, merge the branch locally to check for potential conflicts.
  • If a bug, locally reproduce it and compare energy consumptions before and after.
  • Explore creative ways to stress-test the code.
  • Locally check the error file and other outputs.

@simularis
Copy link
Copy Markdown
Contributor Author

See attached for annual consumption, measure definitions, and UES:
SWSV015-01 Energy Savings Calculations 2025-01-23.xlsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant