Skip to content

SWHC004 residential revision due to QC findings #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
behzadsalimian wants to merge 13 commits into
base: main
Choose a base branch
from
Open

SWHC004 residential revision due to QC findings #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ae69fb8
Parameterized outdoor air reset temperature
behzadsalimian Aug 7, 2025
61020a2
Modified cases files
behzadsalimian Aug 7, 2025
68973d7
Revised conversion factor for W to kBtu/h
behzadsalimian Aug 7, 2025
f6ec3d8
Changed the column header "boiler_eff" to "steam_boiler_eff" to match…
behzadsalimian Aug 13, 2025
f36331e
Move prototypes to "templates" subfolder following convention
nfette Oct 24, 2025
415853b
Removed model setup folder for the "New" vintage
behzadsalimian Mar 12, 2026
52b1d1b
Revised OutdoorAirReset object in the prototype
behzadsalimian Mar 12, 2026
1f3ff1d
Revised OutdoorAirReset object in the prototype
behzadsalimian Mar 12, 2026
d4c1c5c
Revised OutdoorAireReset temperature in the prototype
behzadsalimian Mar 12, 2026
f5ba2a4
Commented out the OutdoorAirReset temperature for the steam boiler
behzadsalimian Mar 12, 2026
1d97f2d
Revised cases files
behzadsalimian Mar 12, 2026
b6755f2
Removed comments for SetpointManager:OutdoorAirReset object
behzadsalimian Mar 16, 2026
5faaa6d
Merge pull request #58 from simularis/dev-SWHC004-residential-qc2
behzadsalimian Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 12 additions & 18 deletions ...sidential/MFm-1985-boiler/root_boiler.pxt → ...MFm-1985-boiler/templates/root_boiler.pxt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,11 @@ parameter "boiler_eff_curve", :default=>'Cond_Boiler_Eff'
# Efficiency Curve Temperature Evaluation Variable
parameter "curve_evaluation_variable", :default=>'LeavingBoiler'

# Parameterize Setpoint at Outdoor Low/High Temperature added by Behzad Rizi (Solaris Technical), 2026-03-12
parameter "supply_temp_at_lo", :default=>130['F']
parameter "lo_outdoor_temp", :default=>20['F']
parameter "supply_temp_at_hi", :default=>105['F']
parameter "hi_outdoor_temp", :default=>50['F']

#Duct Loss
parameter "total_leakage_ratio", :default=>0.15 #total leakage ratio
Expand Down Expand Up @@ -55130,25 +55135,14 @@ Controller:OutdoorAir,
!- Inputs based on EnergyPlus defaults and boiler library.

!- =========== ALL OBJECTS IN CLASS: SETPOINTMANAGER:OUTDOORAIRRESET ===========

SetpointManager:OutdoorAirReset,
Hot Water Loop Setpoint Manager, !- Name
Temperature, !- Control Variable
93.3333333333333, !- Setpoint at Outdoor Low Temperature {C}
-17.7777777777778, !- Outdoor Low Temperature {C}
40, !- Setpoint at Outdoor High Temperature {C}
21.1111111111111, !- Outdoor High Temperature {C}
Hot Water Loop Setpoint Node List; !- Setpoint Node or NodeList Name

SetpointManager:OutdoorAirReset,
Boiler Setpoint Manager, !- Name
Temperature, !- Control Variable
73.88888888888888, !- Setpoint at Outdoor Low Temperature {C}
-17.7777777777778, !- Outdoor Low Temperature {C}
60, !- Setpoint at Outdoor High Temperature {C}
21.1111111111111, !- Outdoor High Temperature {C}
Boiler Water Oulet Node; !- Setpoint Node or NodeList Name

Hot Water Loop Setpoint Manager, !- Name
Temperature, !- Control Variable
<%= supply_temp_at_lo %>, !- Setpoint at Outdoor Low Temperature
<%= lo_outdoor_temp %>, !- Outdoor Low Temperature
<%= supply_temp_at_hi %>, !- Setpoint at Outdoor High Temperature
<%= hi_outdoor_temp %>, !- Outdoor High Temperature
Hot Water Loop Setpoint Node List; !- Setpoint Node or NodeList Name

!- =========== ALL OBJECTS IN CLASS: CURVE:BICUBIC ===========

Expand Down
1 change: 0 additions & 1 deletion ...ial/MFm-1985-boiler/root_steam_boiler.pxt → ...85-boiler/templates/root_steam_boiler.pxt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54998,7 +54998,6 @@ Controller:OutdoorAir,
!- Inputs based on EnergyPlus defaults and boiler library.

!- =========== ALL OBJECTS IN CLASS: SETPOINTMANAGER:OUTDOORAIRRESET ===========

SetpointManager:OutdoorAirReset,
Boiler Setpoint Manager, !- Name
Temperature, !- Control Variable
Expand Down
10 changes: 8 additions & 2 deletions prototypes/residential/MFm-New-boiler/root_boiler_new.pxt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,12 @@ parameter "boiler_eff_curve", :default=>'Cond_Boiler_Eff'
# Efficiency Curve Temperature Evaluation Variable
parameter "curve_evaluation_variable", :default=>'LeavingBoiler'

# Parameters for Setpoint at Outdoor Low/High Temperature added by Behzad Rizi (Solaris Technical), 2025-08-06
# Setpoint at Outdoor Low Temperature
parameter "setpoint_oa_low_temp", :default=>165

# Setpoint at Outdoor High Temperature
parameter "setpoint_oa_high_temp", :default=>140
#Duct Loss
parameter "total_leakage_ratio", :default=>0.12 #total leakage ratio
parameter "number_of_stories", :default=>1 #no. of stories, default one story
Expand Down Expand Up @@ -55221,9 +55227,9 @@ SetpointManager:OutdoorAirReset,
SetpointManager:OutdoorAirReset,
Boiler Setpoint Manager, !- Name
Temperature, !- Control Variable
73.88888888888888, !- Setpoint at Outdoor Low Temperature {C}
<%= setpoint_oa_low_temp %>, !- Setpoint at Outdoor Low Temperature {C}
-17.7777777777778, !- Outdoor Low Temperature {C}
60, !- Setpoint at Outdoor High Temperature {C}
<%= setpoint_oa_high_temp %>, !- Setpoint at Outdoor High Temperature {C}
21.1111111111111, !- Outdoor High Temperature {C}
Boiler Water Oulet Node; !- Setpoint Node or NodeList Name

Expand Down
15 changes: 7 additions & 8 deletions ...HC004-07 Space Heating Boiler_MFm_Ex/cases/MFm&0&rNCHW&Ex&SpaceHtg_eq__HotWaterBoiler.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
skip,case_name,:boiler_eff,:boiler_eff_curve,:curve_evaluation_variable
,AFUE_84_Non-Condensing_baseline,0.84,NonCond_Boiler_Eff,LeavingBoiler
,AFUE_83_Non-Condensing_baseline,0.83,NonCond_Boiler_Eff,LeavingBoiler
#,AFUE_85_Non-Condensing_baseline,0.85,NonCond_Boiler_Eff,LeavingBoiler
,Msr_AFUE_93_ Condensing_ECM,0.93,Cond_Boiler_Eff,EnteringBoiler
,Msr_AFUE_94_ Condensing_ECM,0.94,Cond_Boiler_Eff,EnteringBoiler
,Msr_AFUE_85_Non-Condensing_ECM,0.85,NonCond_Boiler_Eff,LeavingBoiler
,Msr_AFUE_85.3_Non-Condensing_ECM,0.853,NonCond_Boiler_Eff,LeavingBoiler
skip,case_name,:boiler_eff,:boiler_eff_curve,:curve_evaluation_variable,:setpoint_oa_low_temp,:setpoint_oa_high_temp
,RG-SpaceHtg_eq-Boiler-Non-Cond-83-TE,0.83,NonCond_Boiler_Eff,LeavingBoiler,130['F'],105['F']
,RG-SpaceHtg_eq-Boiler-Non-Cond-84-TE,0.84,NonCond_Boiler_Eff,LeavingBoiler,130['F'],105['F']
,RG-SpaceHtg_eq-Boiler-Cond-94-TE,0.94,Cond_Boiler_Eff,EnteringBoiler,130['F'],105['F']
,RG-SpaceHtg_eq-Boiler-Cond-93-TE,0.93,Cond_Boiler_Eff,EnteringBoiler,130['F'],105['F']
,RG-SpaceHtg_eq-Boiler-Non-Cond-85-TE,0.85,NonCond_Boiler_Eff,LeavingBoiler,130['F'],105['F']
,RG-SpaceHtg_eq-Boiler-Non-Cond-85.3-TE,0.853,NonCond_Boiler_Eff,LeavingBoiler,130['F'],105['F']
4 changes: 2 additions & 2 deletions .../SWHC004-07 Space Heating Boiler_MFm_Ex/cases/MFm&0&rNCHW&Ex&SpaceHtg_eq__SteamBoiler.csv
View file
Open in desktop
Copy link
Copy Markdown
Contributor

@simularis simularis Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm name of boiler efficiency for this cohort. Previously steam_boiler_eff.

Copy link
Copy Markdown
Contributor Author

@behzadsalimian behzadsalimian Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed "boiler_eff" to "steam_boiler_eff" to match the defined parameter in the prototype.

Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
skip,case_name,:steam_boiler_eff
,TE_81_Steam_baseline,0.81
,Msr_TE_82_ECM,0.82
,RG-SpaceHtg_eq-Boiler-Steam-82-TE,0.82
,RG-SpaceHtg_eq-Boiler-Steam-81-TE,0.81
8 changes: 0 additions & 8 deletions ...004-07 Space Heating Boiler_MFm_New/cases/MFm&0&rNCHW&New&SpaceHtg_eq__HotWaterBoiler.csv
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions ...WHC004-07 Space Heating Boiler_MFm_New/cases/MFm&0&rNCHW&New&SpaceHtg_eq__SteamBoiler.csv
View file
Open in desktop

This file was deleted.

17 changes: 0 additions & 17 deletions ...ures/SWHC004-07 Space Heating Boiler/SWHC004-07 Space Heating Boiler_MFm_New/climates.csv
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions ...sures/SWHC004-07 Space Heating Boiler/SWHC004-07 Space Heating Boiler_MFm_New/cohorts.csv
View file
Open in desktop

This file was deleted.

29 changes: 0 additions & 29 deletions ...easures/SWHC004-07 Space Heating Boiler/SWHC004-07 Space Heating Boiler_MFm_New/query.txt
View file
Open in desktop

This file was deleted.

32 changes: 0 additions & 32 deletions ...4-07 Space Heating Boiler/SWHC004-07 Space Heating Boiler_MFm_New/query_boiler_sizing.txt
View file
Open in desktop

This file was deleted.

3 changes: 2 additions & 1 deletion scripts/data transformation/insert_normunits.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
* 2024-04-06 Make dependence on measure list and NumStor2 more explicit.
* ... Include more error checking and progress statements.
* 2024-04-08 Updates for commercial building type compatibility.
* 2025-08-06 Changed conversion factor "W" to "kBtu/h" from 3.412141633 to 0.003412141633.

@Author: Nicholas Fette, Behzad Salimian Rizi
@Date: 2024-01-19
Expand Down Expand Up @@ -209,7 +210,7 @@ def test():
normunit = 'CapOut-kBtuh'

# Specify a multipler, e.g. for a unit conversion.
kbtuh_per_watt = 3.412141633
kbtuh_per_watt = 0.003412 # Correct: W → kBtu/h
sizing_multiplier = 1/kbtuh_per_watt

measure_name = 'Wall Furnace'
Expand Down