SWHC004 residential revision due to QC findings#117
Open
behzadsalimian wants to merge 13 commits intosound-data:mainfrom
Open
SWHC004 residential revision due to QC findings#117behzadsalimian wants to merge 13 commits intosound-data:mainfrom
behzadsalimian wants to merge 13 commits intosound-data:mainfrom
Conversation
simularis
reviewed
Aug 12, 2025
Contributor
There was a problem hiding this comment.
Confirm name of boiler efficiency for this cohort. Previously steam_boiler_eff.
Contributor
Author
There was a problem hiding this comment.
Changed "boiler_eff" to "steam_boiler_eff" to match the defined parameter in the prototype.
… the root file naming convention.
simularis
approved these changes
Aug 22, 2025
Contributor
simularis
left a comment
There was a problem hiding this comment.
Internal review by Solaris Technical completed.
Contributor
Author
|
The techIDs for residential don't follow the naming convention to start with "RG" instead of "NG". We will not change unless specifically requested (to keep our simulation results matching with the GiHub). |
SWHC004-MFm- Revised OAT temperature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) Description
This PR addresses several outstanding issues for the SWHC004 Residential analysis workflow
Contributor Email: brizi@solaris-technical.com
PR Review Checklist
PR Owner
PR Author
PR Reviewer