Fix HMI errors during application registration#111
Open
AKalinich-Luxoft wants to merge 2 commits intosmartdevicelink:developfrom
Open
Fix HMI errors during application registration#111AKalinich-Luxoft wants to merge 2 commits intosmartdevicelink:developfrom
AKalinich-Luxoft wants to merge 2 commits intosmartdevicelink:developfrom
Conversation
Sometimes application model for specified app_id could not be found in RPCController array and it returns null object. However widgetPhone view does not handle that case so sometimes it could be seen errors in console output related to that problem. Null check was added in this commit.
There was a problem that RC applications from another device was not displayed in HMI app list. This issue was related to redundant logic of checking RC application properties such as device info. Now this logic is not required so RC applications must behave as well as non-RC applications.
This was referenced Aug 28, 2018
ghost
approved these changes
Aug 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following changes were done:
Sometimes application model for specified app_id could not be found in RPCController array and it returns null object. However widgetPhone view does not handle that case so sometimes it could be seen errors in console output related to that problem.
There was a problem that RC applications from another device was not displayed in HMI app list. This issue was related to redundant logic of checking RC application properties such as device info. Now this logic is not required so RC applications must behave as well as non-RC applications.
Fixes #112