Update remote control radio parameter · Pull Request #93 · smartdevicelink/sdl_hmi

ghost · 2018-06-15T10:42:53Z

Technical task: smartdevicelink/sdl_core#2162
Add new parameter to RadioControlData:

hdRadioEnable
Update max value from 3 to 7 for the next parameters:
availableHDs
hdChannel
Add new radio control capabilities:
hdRadioenableAvailable
siriusxmRadioAvailable

yang1070 · 2018-06-15T13:14:02Z

app/model/media/RadioModel.js

+    false
+  ],
+
+  hdChannelAvailableCurrent:[


why it is an array?

@yang1070 This is array, because we can access the array to index which that the matches with available channel. And that's why we can to take off channel on the radio view. If it was a structure, we doesn't can to do that.

@ValeriiMalkov thank you

yang1070

There need a change in the case that when hdRadioEnabled changes from false to true, the OnInteriorVehicleData notifications shall include all parameters related to HD radio, not just the hdRadioEnabled parameter only. Similarly, for the response of SetInteriorVehicleData that turns on the hdRadio, all HD related parameters shall be included.

yang1070 · 2018-06-15T14:20:26Z

Another requirement is that the XM radio channel number shall be the same as in the frequency integer. When click a XM radio station name in HMI, the frequency integer shall show the XM channel number.
When set a XM with channel number, HMI shall select the corresponding station number.

ghost · 2018-06-15T15:09:55Z

@yang1070 You can see fix hdRadioEnabled with related parameters at the commit 17dc458

yang1070 · 2018-06-18T12:59:49Z

@ValeriiMalkov I haven't see any update for the XM radio channel number update so far.

LitvinenkoIra · 2018-06-18T15:03:02Z

@yang1070 Sorry, updates for XM radio channel number are still in progress

BSolonenko · 2018-06-19T09:00:28Z

@yang1070 In commit a199fb7, I made the necessary changes to the XM radio.
Also, in b4ad697 I added the file with RC capabilities.

yang1070 · 2018-06-21T16:28:17Z

app/model/media/RadioModel.js

+            }
+            break;
+          default:
+            properties.push('signalStrength');


these three properties shall be in AM and FM too

yang1070

The changes look good to me.

yang1070 · 2018-06-22T19:34:29Z

@theresalech Ford reviewed, tested and approves this change.

jacobkeeler · 2018-08-17T23:36:27Z

@ValeriiMalkov please fix merge conflicts

AKalinich-Luxoft · 2018-08-21T08:53:09Z

@jacobkeeler all merge conflicts have been resolved

ghost · 2018-08-27T14:24:21Z

@jacobkeeler, PR was rebased to develop branch

jacobkeeler · 2018-08-27T14:33:12Z

capabilities/rc_capabilities.js

+        longPressAvailable: false,
+        upDownAvailable: false
+    }],
+    audioControlCapabilities: [{


audioControlCapabilities already exists in this file

@jacobkeeler This issue was resolved after rebase

jacobkeeler · 2018-08-27T14:34:15Z

capabilities/rc_capabilities.js

+        frontVerticalPositionAvailable: true,
+        headSupportHorizontalPositionAvailable: true
+    }],
+    buttonCapabilities: [{


buttonCapabilities already exists in this file

@jacobkeeler This issue was resolved after rebase

jacobkeeler · 2018-08-27T14:40:08Z

index.html

        src="app/view/navigationApp/baseNavigationView.js"></script>
 <script type="text/javascript" src="app/view/navigationAppView.js"></script>

+<!-- SDL Capabilities -->


Already exists: https://github.com/smartdevicelink/sdl_hmi/pull/93/files#diff-eacf331f0ffc35d4b482f1d15a887d3bR257

@jacobkeeler This issue was resolved after rebase

jacobkeeler · 2018-08-27T14:40:54Z

capabilities/rc_capabilities.js

        upDownAvailable: false
    }],
    climateControlCapabilities: [{
+        moduleName: 'Climate Control Module',


moduleName already exists for this capability object

@jacobkeeler This issue was resolved after rebase

Most of the issues were fixed, but this wasn't:

sdl_hmi/capabilities/rc_capabilities.js

Line 110 in e0f4d08

moduleName: 'primary_climate',

@jacobkeeler we leave rc_capabilities.js version from develop branch and add two new parameters. All other changes were reverted. See 9de70a2

GetmanetsIrina · 2018-08-27T15:16:06Z

@jacobkeeler, HMI is tested after rebase, works according to proposal.

Add new parameter to RadioControlData: - `hdRadioEnable` Update max value from 3 to 7 for the next parameters: - `availableHDs` - `hdChannel` Add new radio control capabilities: - `hdRadioenableAvailable` - `siriusxmRadioAvailable`

Add parameters to notification in case when switching hdRadio enable

AStasiuk · 2018-08-27T19:11:22Z

@jacobkeeler, all comments are processed, please have a look.

Jack-Byrne · 2018-08-27T19:40:28Z

capabilities/rc_capabilities.js

        ventilationModeAvailable: true
    }],
    radioControlCapabilities: [{
+        moduleName: 'Radio Control Module',


missing hdRadioEnableAvailable from radioControlCapabilities

@JackLivio new parameters hdRadioEnableAvailable and siriusxmRadioAvailable was added. See 9de70a2

jacobkeeler · 2018-08-27T19:21:33Z

capabilities/rc_capabilities.js

        upDownAvailable: false
    }],
    climateControlCapabilities: [{
+        moduleName: 'Climate Control Module',


Most of the issues were fixed, but this wasn't:

sdl_hmi/capabilities/rc_capabilities.js

Line 110 in e0f4d08

moduleName: 'primary_climate',

jacobkeeler · 2018-08-27T19:22:10Z

capabilities/rc_capabilities.js

        ventilationModeAvailable: true
    }],
    radioControlCapabilities: [{
+        moduleName: 'Radio Control Module',


Now this one is a duplicate key (see line 118)

@jacobkeeler fixed in 9de70a2

Add new radio control capabilities: hdRadioenableAvailable siriusxmRadioAvailable

GetmanetsIrina · 2018-08-28T12:06:26Z

@jacobkeeler , regarding the issue with the registration of several apps from different devices - bug was created #112 .
Also there is fix for this issue in #111 .

AStasiuk requested review from askirk, mrapitis, robinmk and yang1070 June 15, 2018 10:50

yang1070 reviewed Jun 15, 2018

View reviewed changes

yang1070 suggested changes Jun 15, 2018

View reviewed changes

BSolonenko mentioned this pull request Jun 19, 2018

Feature/rc lights more names and status values #92

Merged

BSolonenko force-pushed the feature/rc_radio_parameter_update branch 7 times, most recently from 490daba to cb828c0 Compare June 21, 2018 11:01

yang1070 reviewed Jun 21, 2018

View reviewed changes

BSolonenko force-pushed the feature/rc_radio_parameter_update branch 2 times, most recently from 12fa09d to 2d71ea6 Compare June 22, 2018 16:13

yang1070 approved these changes Jun 22, 2018

View reviewed changes

BSolonenko force-pushed the feature/rc_radio_parameter_update branch 2 times, most recently from e0d4cd1 to c80210a Compare June 23, 2018 14:58

yang1070 approved these changes Jun 23, 2018

View reviewed changes

AKalinich-Luxoft force-pushed the feature/rc_radio_parameter_update branch 2 times, most recently from e2f2180 to 6c6514a Compare August 20, 2018 17:15

AKalinich-Luxoft force-pushed the feature/rc_radio_parameter_update branch 3 times, most recently from cdd76ac to 33ca053 Compare August 20, 2018 18:24

ghost force-pushed the feature/rc_radio_parameter_update branch from ac8cd93 to 984c991 Compare August 27, 2018 13:54

jacobkeeler requested changes Aug 27, 2018

View reviewed changes

ghost force-pushed the feature/rc_radio_parameter_update branch 3 times, most recently from f076885 to b90f1a3 Compare August 27, 2018 16:10

Valerii and others added 3 commits August 27, 2018 19:24

Update remote control radio parameter

32f9979

Add new parameter to RadioControlData: - `hdRadioEnable` Update max value from 3 to 7 for the next parameters: - `availableHDs` - `hdChannel` Add new radio control capabilities: - `hdRadioenableAvailable` - `siriusxmRadioAvailable`

Add parameters to notification hdRadioEnable

16c17ae

Add parameters to notification in case when switching hdRadio enable

Fix XM channel numbers.

7cbba3b

ghost force-pushed the feature/rc_radio_parameter_update branch from b90f1a3 to e0f4d08 Compare August 27, 2018 16:25

Jack-Byrne reviewed Aug 27, 2018

View reviewed changes

jacobkeeler requested changes Aug 27, 2018

View reviewed changes

BSolonenko and others added 5 commits August 28, 2018 10:43

Added file with RC_Capabilities.

9de70a2

Add new radio control capabilities: hdRadioenableAvailable siriusxmRadioAvailable

Fixed onInteriorVehicleDataNotification

9f7de60

Fixed OnInteriorVehicleData and GetInteriorVehicleData

3431d90

fix sending sisData

56cd98c

Fixed formatting and fixes after rebase

0f69786

AKalinich-Luxoft force-pushed the feature/rc_radio_parameter_update branch from e0f4d08 to 0f69786 Compare August 28, 2018 07:44

jacobkeeler approved these changes Aug 28, 2018

View reviewed changes

jacobkeeler merged commit 3e81a3f into develop Aug 28, 2018

Jack-Byrne mentioned this pull request Oct 19, 2018

Release 5.0.0 #153

Merged

jacobkeeler deleted the feature/rc_radio_parameter_update branch March 18, 2020 13:19

Conversation

ghost commented Jun 15, 2018 • edited by AStasiuk Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yang1070 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yang1070 commented Jun 15, 2018

Uh oh!

ghost commented Jun 15, 2018

Uh oh!

yang1070 commented Jun 18, 2018

Uh oh!

LitvinenkoIra commented Jun 18, 2018

Uh oh!

BSolonenko commented Jun 19, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yang1070 left a comment

Choose a reason for hiding this comment

Uh oh!

yang1070 commented Jun 22, 2018

Uh oh!

jacobkeeler commented Aug 17, 2018

Uh oh!

AKalinich-Luxoft commented Aug 21, 2018

Uh oh!

ghost commented Aug 27, 2018 • edited by AStasiuk Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jacobkeeler Aug 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GetmanetsIrina commented Aug 27, 2018

Uh oh!

AStasiuk commented Aug 27, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jacobkeeler Aug 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GetmanetsIrina commented Aug 28, 2018

Uh oh!

Reviewers

Assignees

ghost commented Jun 15, 2018 •

edited by AStasiuk

Loading

yang1070 left a comment •

edited

Loading

ghost commented Aug 27, 2018 •

edited by AStasiuk

Loading

jacobkeeler Aug 27, 2018 •

edited

Loading

jacobkeeler Aug 27, 2018 •

edited

Loading