Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
42910e1
SK-1910: Updated generated code with fern
saileshwar-skyflow Mar 23, 2025
af115c4
SK-1910: Added dependencies
saileshwar-skyflow Mar 27, 2025
62efe88
SK-1978 add fern generated code for detect
raushan-skyflow May 25, 2025
e208f57
SK-1978 add public interface for deidentify text detect support
raushan-skyflow May 26, 2025
a60cf80
SK-1978 add public interface for deidentify & reidentify text with un…
raushan-skyflow May 28, 2025
55287ae
SK-1978 updated masking method, thrown skyflow exception & fixed unit…
raushan-skyflow Jun 4, 2025
21e94db
SK-1978 address the review comments
raushan-skyflow Jun 9, 2025
991a4fc
SK-2071: add deidentify file interface
saileshwar-skyflow Jun 11, 2025
1b6afe5
SK-2071: revert api key validation
saileshwar-skyflow Jun 11, 2025
59eae38
SK-2071: increase coverage and add private constructor
saileshwar-skyflow Jun 16, 2025
4d51813
SK-2071 update error handling, message and validation of detect text …
raushan-skyflow Jun 19, 2025
3c528d8
SK-2071 update toString method in deidentify file response and return…
raushan-skyflow Jun 20, 2025
5654a4d
SK-2071 add map audio data format
raushan-skyflow Jun 24, 2025
253aefc
SK-2140: send file object in response and accept file path in request…
saileshwar-skyflow Jun 25, 2025
d0579ac
SK-2143: add junit dependency
saileshwar-skyflow Jun 25, 2025
33e1afc
SK-2143: fix pom.xml
saileshwar-skyflow Jun 25, 2025
f776491
SK-2143: add plugin for javadoc
saileshwar-skyflow Jun 25, 2025
90a34d6
SK-2143: update tests run command
saileshwar-skyflow Jun 25, 2025
62733bb
SK-2071 add unit test for vault,detect and connection config
raushan-skyflow Jun 26, 2025
7ae3147
SK-2147: resolve comments and add tests
saileshwar-skyflow Jun 26, 2025
06f1872
SK-2071 update skyflow exception class & unit test
raushan-skyflow Jun 27, 2025
2584322
SK-2071: resolve comments
saileshwar-skyflow Jun 27, 2025
48bf294
SK-2071: Merge branch 'v2' into saileshwar-skyflow/SK-2071-deidentify…
saileshwar-skyflow Jun 27, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
echo TEST_REUSABLE_TOKEN=${{ secrets.TEST_REUSABLE_TOKEN }} >> .env

- name: Build & Run tests with Maven
run: mvn -B package -f pom.xml
run: mvn -B package -f pom.xml -Dmaven.javadoc.skip=true

- name: Codecov
uses: codecov/codecov-action@v2.1.0
Expand Down
31 changes: 30 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,30 @@
</properties>

<dependencies>
<dependency>
<groupId>com.squareup.okhttp3</groupId>
<artifactId>okhttp</artifactId>
<version>4.12.0</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<version>2.17.2</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.datatype</groupId>
<artifactId>jackson-datatype-jdk8</artifactId>
<version>2.17.2</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.datatype</groupId>
<artifactId>jackson-datatype-jsr310</artifactId>
<version>2.17.2</version>
<scope>compile</scope>
</dependency>
<!-- newly added v2 dependencies -->
<dependency>
<groupId>io.github.cdimascio</groupId>
Expand Down Expand Up @@ -117,6 +141,12 @@
<version>2.0.9</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter</artifactId>
<version>RELEASE</version>
<scope>compile</scope>
</dependency>
</dependencies>

<build>
Expand Down Expand Up @@ -276,5 +306,4 @@
</distributionManagement>
</profile>
</profiles>

</project>
47 changes: 43 additions & 4 deletions src/main/java/com/skyflow/Skyflow.java
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import com.skyflow.utils.logger.LogUtil;
import com.skyflow.utils.validations.Validations;
import com.skyflow.vault.controller.ConnectionController;
import com.skyflow.vault.controller.DetectController;
import com.skyflow.vault.controller.VaultController;

import java.util.LinkedHashMap;
Expand Down Expand Up @@ -101,25 +102,57 @@
return controller;
}

public ConnectionController connection() {
String connectionId = (String) this.builder.connectionsMap.keySet().toArray()[0];

public ConnectionController connection() throws SkyflowException {
Object[] array = this.builder.connectionsMap.keySet().toArray();

Check warning on line 107 in src/main/java/com/skyflow/Skyflow.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/com/skyflow/Skyflow.java#L107

Added line #L107 was not covered by tests
if (array.length < 1) {
LogUtil.printErrorLog(ErrorLogs.CONNECTION_CONFIG_DOES_NOT_EXIST.getLog());
throw new SkyflowException(ErrorCode.INVALID_INPUT.getCode(), ErrorMessage.ConnectionIdNotInConfigList.getMessage());

Check warning on line 110 in src/main/java/com/skyflow/Skyflow.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/com/skyflow/Skyflow.java#L109-L110

Added lines #L109 - L110 were not covered by tests
}
String connectionId = (String) array[0];

Check warning on line 112 in src/main/java/com/skyflow/Skyflow.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/com/skyflow/Skyflow.java#L112

Added line #L112 was not covered by tests
return this.connection(connectionId);
}

public ConnectionController connection(String connectionId) {
return this.builder.connectionsMap.get(connectionId);
public ConnectionController connection(String connectionId) throws SkyflowException {
ConnectionController controller = this.builder.connectionsMap.get(connectionId);

Check warning on line 117 in src/main/java/com/skyflow/Skyflow.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/com/skyflow/Skyflow.java#L117

Added line #L117 was not covered by tests
if (controller == null) {
LogUtil.printErrorLog(ErrorLogs.CONNECTION_CONFIG_DOES_NOT_EXIST.getLog());
throw new SkyflowException(ErrorCode.INVALID_INPUT.getCode(), ErrorMessage.ConnectionIdNotInConfigList.getMessage());

Check warning on line 120 in src/main/java/com/skyflow/Skyflow.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/com/skyflow/Skyflow.java#L119-L120

Added lines #L119 - L120 were not covered by tests
}
return controller;

Check warning on line 122 in src/main/java/com/skyflow/Skyflow.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/com/skyflow/Skyflow.java#L122

Added line #L122 was not covered by tests
}

public DetectController detect() throws SkyflowException {
Object[] array = this.builder.detectClientsMap.keySet().toArray();

Check warning on line 126 in src/main/java/com/skyflow/Skyflow.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/com/skyflow/Skyflow.java#L126

Added line #L126 was not covered by tests
if (array.length < 1) {
LogUtil.printErrorLog(ErrorLogs.VAULT_CONFIG_DOES_NOT_EXIST.getLog());
throw new SkyflowException(ErrorCode.INVALID_INPUT.getCode(), ErrorMessage.VaultIdNotInConfigList.getMessage());

Check warning on line 129 in src/main/java/com/skyflow/Skyflow.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/com/skyflow/Skyflow.java#L128-L129

Added lines #L128 - L129 were not covered by tests
}
String detectId = (String) array[0];
return this.detect(detectId);

Check warning on line 132 in src/main/java/com/skyflow/Skyflow.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/com/skyflow/Skyflow.java#L131-L132

Added lines #L131 - L132 were not covered by tests
}

public DetectController detect(String vaultId) throws SkyflowException {
DetectController controller = this.builder.detectClientsMap.get(vaultId);

Check warning on line 136 in src/main/java/com/skyflow/Skyflow.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/com/skyflow/Skyflow.java#L136

Added line #L136 was not covered by tests
if (controller == null) {
LogUtil.printErrorLog(ErrorLogs.VAULT_CONFIG_DOES_NOT_EXIST.getLog());
throw new SkyflowException(ErrorCode.INVALID_INPUT.getCode(), ErrorMessage.VaultIdNotInConfigList.getMessage());

Check warning on line 139 in src/main/java/com/skyflow/Skyflow.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/com/skyflow/Skyflow.java#L138-L139

Added lines #L138 - L139 were not covered by tests
}
return controller;

Check warning on line 141 in src/main/java/com/skyflow/Skyflow.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/com/skyflow/Skyflow.java#L141

Added line #L141 was not covered by tests
}

public static final class SkyflowClientBuilder {
private final LinkedHashMap<String, ConnectionController> connectionsMap;
private final LinkedHashMap<String, VaultController> vaultClientsMap;
private final LinkedHashMap<String, DetectController> detectClientsMap;
private final LinkedHashMap<String, VaultConfig> vaultConfigMap;
private final LinkedHashMap<String, ConnectionConfig> connectionConfigMap;
private Credentials skyflowCredentials;
private LogLevel logLevel;

public SkyflowClientBuilder() {
this.vaultClientsMap = new LinkedHashMap<>();
this.detectClientsMap = new LinkedHashMap<>();

Check warning on line 155 in src/main/java/com/skyflow/Skyflow.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/com/skyflow/Skyflow.java#L155

Added line #L155 was not covered by tests
this.vaultConfigMap = new LinkedHashMap<>();
this.connectionsMap = new LinkedHashMap<>();
this.connectionConfigMap = new LinkedHashMap<>();
Expand All @@ -139,8 +172,11 @@
} else {
this.vaultConfigMap.put(vaultConfig.getVaultId(), vaultConfig);
this.vaultClientsMap.put(vaultConfig.getVaultId(), new VaultController(vaultConfig, this.skyflowCredentials));
this.detectClientsMap.put(vaultConfig.getVaultId(), new DetectController(vaultConfig, this.skyflowCredentials));

Check warning on line 175 in src/main/java/com/skyflow/Skyflow.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/com/skyflow/Skyflow.java#L175

Added line #L175 was not covered by tests
LogUtil.printInfoLog(Utils.parameterizedString(
InfoLogs.VAULT_CONTROLLER_INITIALIZED.getLog(), vaultConfig.getVaultId()));
LogUtil.printInfoLog(Utils.parameterizedString(
InfoLogs.DETECT_CONTROLLER_INITIALIZED.getLog(), vaultConfig.getVaultId()));

Check warning on line 179 in src/main/java/com/skyflow/Skyflow.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/com/skyflow/Skyflow.java#L178-L179

Added lines #L178 - L179 were not covered by tests
}
return this;
}
Expand Down Expand Up @@ -226,6 +262,9 @@
for (VaultController vault : this.vaultClientsMap.values()) {
vault.setCommonCredentials(this.skyflowCredentials);
}
for (DetectController detect : this.detectClientsMap.values()) {
detect.setCommonCredentials(this.skyflowCredentials);
}

Check warning on line 267 in src/main/java/com/skyflow/Skyflow.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/com/skyflow/Skyflow.java#L266-L267

Added lines #L266 - L267 were not covered by tests
for (ConnectionController connection : this.connectionsMap.values()) {
connection.setCommonCredentials(this.skyflowCredentials);
}
Expand Down
Loading
Loading