SK-2071: Fern Integration and Detect Support #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

saileshwar-skyflow merged 23 commits into release/25.6.2 from saileshwar-skyflow/SK-2071-deidentify-file

Jun 27, 2025

Collaborator

saileshwar-skyflow commented Jun 19, 2025 •

edited

Loading

Why

The Java SDK did not support Detect APIs, requiring developers to call them manually.
The SDK previously used OpenAPI Generator for its internal code structure.

Outcome

Added support for Detect APIs in the Java SDK.
Migrated the internal code generation framework from OpenAPI Generator to Fern.

saileshwar-skyflow and others added 14 commits

March 24, 2025 01:10


          SK-1910: Updated generated code with fern

42910e1


          SK-1910: Added dependencies

af115c4


          SK-1978 add fern generated code for detect

62efe88


          SK-1978 add public interface for deidentify text detect support

e208f57


          SK-1978 add public interface for deidentify & reidentify text with un…

a60cf80

…it test


          SK-1978 updated masking method, thrown skyflow exception & fixed unit…

55287ae

… test


          SK-1978 address the review comments

21e94db


          SK-2071: add deidentify file interface

991a4fc


          SK-2071: revert api key validation

1b6afe5


          SK-2071: increase coverage and add private constructor

59eae38


          SK-2071 update error handling, message and validation of detect text …

4d51813

…with tests


          SK-2071 update toString method in deidentify file response and return…

3c528d8

… type


          SK-2071 add map audio data format

5654a4d


          SK-2140: send file object in response and accept file path in request…

253aefc

… and fix inconsistencies

saileshwar-skyflow changed the base branch from SK-1910-migrate-from-openapigenerator-to-fern to saileshwar-skyflow/SK-1910-migrate-from-openapigenerator-to-fern

June 25, 2025 19:36

saileshwar-skyflow added 4 commits

June 26, 2025 01:08


          SK-2143: add junit dependency

d0579ac


          SK-2143: fix pom.xml

33e1afc


          SK-2143: add plugin for javadoc

f776491


          SK-2143: update tests run command

90a34d6

saileshwar-skyflow changed the title ~~SK-2071: Implement Deidentify File Interface and Polling for Detect Support~~ SK-2071: Fern Integration and Detect Support

skyflow-vivek reviewed

View reviewed changes

src/main/java/com/skyflow/VaultClient.java Outdated Show resolved Hide resolved

skyflow-vivek reviewed

View reviewed changes

src/main/java/com/skyflow/VaultClient.java Show resolved Hide resolved

skyflow-vivek reviewed

View reviewed changes

src/main/java/com/skyflow/VaultClient.java Outdated Show resolved Hide resolved

skyflow-vivek reviewed

View reviewed changes

src/main/java/com/skyflow/VaultClient.java Show resolved Hide resolved

skyflow-vivek reviewed

View reviewed changes

src/main/java/com/skyflow/errors/SkyflowException.java Outdated Show resolved Hide resolved

skyflow-vivek reviewed

View reviewed changes

src/main/java/com/skyflow/errors/SkyflowException.java Outdated Show resolved Hide resolved


          SK-2071 add unit test for vault,detect and connection config

62733bb

skyflow-vivek reviewed

View reviewed changes

src/main/java/com/skyflow/serviceaccount/util/BearerToken.java Outdated Show resolved Hide resolved

skyflow-vivek reviewed

View reviewed changes

src/main/java/com/skyflow/vault/controller/DetectController.java Show resolved Hide resolved

skyflow-vivek reviewed

View reviewed changes

src/main/java/com/skyflow/vault/controller/DetectController.java Outdated Show resolved Hide resolved

skyflow-vivek reviewed

View reviewed changes

src/main/java/com/skyflow/vault/controller/DetectController.java Outdated Show resolved Hide resolved

skyflow-vivek reviewed

View reviewed changes

src/main/java/com/skyflow/vault/controller/DetectController.java Show resolved Hide resolved

skyflow-vivek reviewed

View reviewed changes

src/main/java/com/skyflow/vault/controller/DetectController.java Show resolved Hide resolved

skyflow-vivek reviewed

View reviewed changes

src/main/java/com/skyflow/vault/controller/DetectController.java Show resolved Hide resolved

skyflow-vivek reviewed

View reviewed changes

src/main/java/com/skyflow/vault/controller/DetectController.java Show resolved Hide resolved

saileshwar-skyflow and others added 2 commits

June 27, 2025 00:20


          SK-2147: resolve comments and add tests

7ae3147


          SK-2071 update skyflow exception class & unit test

06f1872

saileshwar-skyflow requested a review from skyflow-vivek

June 27, 2025 07:59

skyflow-vivek reviewed

View reviewed changes

src/test/java/com/skyflow/vault/controller/VaultControllerTests.java Outdated Show resolved Hide resolved

skyflow-vivek reviewed

View reviewed changes

src/test/java/com/skyflow/vault/data/DeleteTests.java Outdated Show resolved Hide resolved

skyflow-vivek reviewed

View reviewed changes

src/test/java/com/skyflow/vault/data/QueryTests.java Show resolved Hide resolved

skyflow-vivek reviewed

View reviewed changes

src/test/java/com/skyflow/vault/data/UpdateTests.java Show resolved Hide resolved

skyflow-vivek reviewed

View reviewed changes

src/test/java/com/skyflow/vault/tokens/DetokenizeTests.java Outdated Show resolved Hide resolved

skyflow-vivek reviewed

View reviewed changes

src/test/java/com/skyflow/vault/tokens/TokenizeTests.java Show resolved Hide resolved

skyflow-vivek reviewed

View reviewed changes

Collaborator

skyflow-vivek left a comment

Deidentify File status can be an enum instead of constants. Please address other comments as well. Otherwise LGTM.


          SK-2071: resolve comments

saileshwar-skyflow requested a review from skyflow-vivek

June 27, 2025 10:29

skyflow-vivek approved these changes

View reviewed changes

skyflow-shravan approved these changes

View reviewed changes

raushan-skyflow approved these changes

View reviewed changes

saileshwar-skyflow changed the base branch from saileshwar-skyflow/SK-1910-migrate-from-openapigenerator-to-fern to release/25.6.1

June 27, 2025 10:59

saileshwar-skyflow changed the base branch from release/25.6.1 to release/25.6.2

June 27, 2025 11:00


          SK-2071: Merge branch 'v2' into saileshwar-skyflow/SK-2071-deidentify…

48bf294

…-file

saileshwar-skyflow merged commit b0d17e8 into release/25.6.2

4 checks passed

saileshwar-skyflow added a commit that referenced this pull request


          SK-2141: Beta Release Fern Integration and Detect Support #179 (#181)

cd9c4b2

* SK-2071: Fern Integration and Detect Support (#179)

saileshwar-skyflow added a commit that referenced this pull request


          SK-2141: Beta Release Fern Integration and Detect Support (#182)

b886165

* SK-2071: Fern Integration and Detect Support (#179)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet