Skip to content

Feature/reject report feedback #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ONEONUORA merged 8 commits into from
Sep 20, 2025
Merged

Feature/reject report feedback #115

ONEONUORA merged 8 commits into from
Sep 20, 2025

Conversation

@Cherrypick14
Copy link
Contributor

@Cherrypick14 Cherrypick14 commented Aug 1, 2025 •
edited
Loading

🎯 Overview

This PR implements the Report Rejection functionality as requested in issue #73 , allowing validators to reject research reports with proper validation and authorization.

✨ Features Implemented

API Endpoint

  • POST /report/reject - New endpoint for rejecting reports
  • Comprehensive input validation using garde framework
  • Proper error handling with appropriate HTTP status codes

Request/Response Structure

// Request
{
  "report_id": "uuid",
  "reason": "duplicate_report|incomplete_information|already_known|out_of_scope",
  "validator_notes": "Optional notes (max 1000 chars)",
  "validated_by": "0x..." // Starknet wallet address
}

// Response
{
  "message": "Report rejected successfully",
  "report_id": "uuid"
}

@Cherrypick14
Copy link
Contributor Author

Cherrypick14 commented Aug 9, 2025

@ONEONUORA , I had opened the PR for the reject report feedback (#115 ). Please review when you get a chance.

@Cherrypick14 Cherrypick14 mentioned this pull request Aug 9, 2025
Open
@Cherrypick14
Fix clippy warnings and code formatting
f2dd36d 
- Add allow(dead_code) attribute to Report struct fields that are part of database schema
- Run cargo fmt to ensure consistent code formatting
- All tests still passing (77/77)
@Cherrypick14
fix: Update SQLx query cache to include test queries
52b4142 
- Regenerate .sqlx/ metadata with test queries included
- This resolves all SQLx offline compilation errors
- IDE red lines should now be completely resolved
@Cherrypick14
Copy link
Contributor Author

Cherrypick14 commented Aug 18, 2025

@ONEONUORA Please review this implementation when you get a chance! The report rejection feature is fully implemented and tested.

ONEONUORA
ONEONUORA approved these changes Sep 20, 2025
View reviewed changes
Copy link
Contributor

@ONEONUORA ONEONUORA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice implementation @Cherrypick14

@ONEONUORA ONEONUORA merged commit de4ccb3 into skill-mind:master Sep 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ONEONUORA ONEONUORA ONEONUORA approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Cherrypick14 @ONEONUORA