Skip to content

Fix AdvantiumCookAction and AdvantiumWarmStatus ValueError for unknown enum values #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
floydpink wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −6
Open

Fix AdvantiumCookAction and AdvantiumWarmStatus ValueError for unknown enum values #110

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
638db4b
Fix AdvantiumCookAction and AdvantiumWarmStatus ValueError for unknow…
floydpink Apr 2, 2026
2744615
Fix AdvantiumCookMode._missing_ to return NO_MODE for any unrecognize…
floydpink Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions gehomesdk/erd/values/advantium/advantium_enums.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ class AdvantiumWarmStatus(enum.IntEnum):
def _missing_(cls, value):
if value == 223:
return cls.OFF
# fall back to default behavior -> raises ValueError
return super()._missing_(value)
return cls.OFF

@enum.unique
class AdvantiumDoorStatus(enum.Enum):
Expand All @@ -53,8 +52,7 @@ class AdvantiumCookAction(enum.IntEnum):
def _missing_(cls, value):
if value in (20, 178):
return cls.STOP
# fall back to default behavior -> raises ValueError
return super()._missing_(value)
return cls.UNKNOWN

@enum.unique
class AdvantiumCookMode(enum.IntEnum):
Expand All @@ -78,8 +76,7 @@ class AdvantiumCookMode(enum.IntEnum):
def _missing_(cls, value):
if value in (153,223,253):
return cls.NO_MODE
# fall back to default behavior -> raises ValueError
return super()._missing_(value)
return cls.NO_MODE


@enum.unique
Expand Down