Fix AdvantiumCookAction and AdvantiumWarmStatus ValueError for unknown enum values#110
Open
floydpink wants to merge 1 commit intosimbaja:masterfrom
Open
Fix AdvantiumCookAction and AdvantiumWarmStatus ValueError for unknown enum values#110floydpink wants to merge 1 commit intosimbaja:masterfrom
floydpink wants to merge 1 commit intosimbaja:masterfrom
Conversation
…n enum values The _missing_ methods for AdvantiumCookAction and AdvantiumWarmStatus raise ValueError for unrecognized values sent by the appliance (e.g., 38 and 250). This causes noisy error logs every ~30 seconds even though the converter catches the exception and falls back to a default. Return a safe default (UNKNOWN/OFF) for any unrecognized value, matching the pattern already used by AdvantiumCookMode._missing_. Fixes simbaja#109
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #109
Problem
The
_missing_methods forAdvantiumCookActionandAdvantiumWarmStatusraiseValueErrorfor unrecognized values sent by the appliance (e.g., values 38 and 250). The converter's try/except catches this and falls back to a completely emptyErdAdvantiumCookSetting(), discarding all fields. This error logs every ~30 seconds, filling the Home Assistant log with noise.Fix
Return a safe default (
UNKNOWN/OFF) for any unrecognized value instead of raising. This matches the pattern already used byAdvantiumCookMode._missing_, which returnsNO_MODEfor values 153, 223, and 253.Effect
ValueError→ entire cook setting discarded, error loggedNo side effects —
UNKNOWNandOFFare existing enum values already handled by downstream code.