Skip to content

Update pwa.html#40

Closed
blackelbow wants to merge 2 commits intosilviolleite:masterfrom
blackelbow:master
Closed

Update pwa.html#40
blackelbow wants to merge 2 commits intosilviolleite:masterfrom
blackelbow:master

Conversation

@blackelbow
Copy link

Include crossorigin to prevent 401 when pwa is behind sign in

Added crossorigin to prevent 401
@Archmonger
Copy link

Hey @silviolleite , I'd like to see this PR reviewed & merged. Without this, django-pwa is not usable in any reverse proxy or auth scenario.

Code changes are only one line.

@silviolleite
Copy link
Owner

Hey @silviolleite , I'd like to see this PR reviewed & merged. Without this, django-pwa is not usable in any reverse proxy or auth scenario.

Code changes are only one line.

Thx @Archmonger
Please, you need to fix the unit tests.

@Archmonger
Copy link

Archmonger commented Mar 31, 2021

@silviolleite I am not the author for this PR, and the original author appears to be inactive on GH.

The fix for the unit test is quite simple.
Line 25 of test_template_tags.py needs to be changed.
Previously was: '<link rel="manifest" href="/manifest.json">',
Needs to be '<link rel="manifest" href="/manifest.json" crossorigin="use-credentials">',

Tests will pass after this change.

@Alex-Sichkar
Copy link
Contributor

I've opened a fresh PR (#140) that includes these changes and resolves the current merge conflicts. Since this branch is inactive, let's proceed with the new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants