fix: add crossorigin attribute to manifest link#140
Merged
hartungstenio merged 1 commit intosilviolleite:masterfrom Mar 4, 2026
Merged
fix: add crossorigin attribute to manifest link#140hartungstenio merged 1 commit intosilviolleite:masterfrom
hartungstenio merged 1 commit intosilviolleite:masterfrom
Conversation
Alex-Sichkar
force-pushed
the
fix/add-manifest-crossorigin
branch
from
54e38d7 to
dfa48c8
Compare
Alex-Sichkar
force-pushed
the
fix/add-manifest-crossorigin
branch
from
dfa48c8 to
b4e9c4c
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
crossorigin="use-credentials"attribute to the web manifest link tag, reviving the inactive work from #40.This is required to ensure that the browser correctly handles authentication (cookies, headers) when fetching the manifest, preventing issues in environments with strict CORS policies or authenticated sessions.