Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an initial attempt to implement phasing detection strategies. See #7 .
test.shto make it runnable on systems without/bin/bashphasedAutodetectto decrease the cognitive loadI'm not happy with my enum+fp-style approach but did not want to change in the middle of coding. Feel free to suggest another approach. Maybe simply OOP inheritance.
Moving
previousaround (see code) is only necessary if you care for performance (while looping over the variants) which is fine as is. Still, it's cumbersome and could be removed if performance is not a concern.ONE_FOR_ALLandDEFAULTare no good names.I am not sure what exactly
phasedAutodetectis expected to mean. I guess the final PR should also touch on this attribute for a consistent approach.