Conversation
…ates and .json files for each quest Removed unneeded default parameter Finalized Jump Four Jaggi, added tentative Rage Match, and added more to the quest formatting system. Added "Flooded Forest Free-For-All" and fixed bug Changed quest rotation system to a .json-based system that's refreshable via the interactive (-i) menu Added bytes for small monster wave transition criteria Added ability to programatically add small monsters Added more programatically-added small monster information Addressed Sepalani comments
Updated Mercy Mission to have corrected small monsters Removed need for .dat small monster files New event quest
InusualZ
approved these changes
Jul 24, 2025
Collaborator
InusualZ
left a comment
InusualZ
left a comment
There was a problem hiding this comment.
Porting seem to be pretty straightforward. Most of the additions come from the json (events).
InusualZ
reviewed
Jul 24, 2025
| self.sendReqMemoryCheck(0x806311a8, 56) | ||
| else: | ||
| PatRequestHandler.sendReqConnection(self) | ||
| elif address in [0x806308e8, 0x806311a8]: |
Collaborator
There was a problem hiding this comment.
I saw this while reviewing the other PR. I think this can be converted into a general purpose check. Since if you are hosting a private server, you may want to check that all the player can play with each other. So maybe adding a NATNEG domain field in the config file and checking that it match it wouldn't bad
Owner
Author
There was a problem hiding this comment.
Yeah, I agree and do plan to add that in a follow-up PR. It'd be especially useful since the Japanese version used a different one (IIRC) and that the domain can also be changed using a (Riivolution) patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backports code from the branches used by the open beta (i.e. event-quest-rotation/event-quest-rotation-full).
It should also fix:
Regarding some of the modification done to the original commits:
Otherwise, I do plan follow-up PRs to address the TODO/backport comments. I think I'll prioritise the MySQL part first, then implement the rest.