Conversation
InusualZ
approved these changes
Jul 24, 2025
Collaborator
InusualZ
left a comment
InusualZ
left a comment
There was a problem hiding this comment.
Only one comment that can be addressed after all the backport is complete.
|
|
||
| def populate_database(self): | ||
| with self.connection.cursor() as cursor: | ||
| cursor.execute("SELECT * FROM consoles") |
Collaborator
There was a problem hiding this comment.
I don't quite like that we are loading the entire table into memory when not all slot may be used. After we land this, this should be refactored into a more lazy operation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds MySQL backend support for both python2/3.
Depends on #133.