Skip to content

Update Memory.js #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AimWhy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Memory.js #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/Memory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import Role from './Role';
import Base from './Base';

export default class Memory extends Storage {
items: Object[] = {};
items: Object = {};

async add(item: Base): boolean {
const { name } = item;
Expand Down Expand Up @@ -94,9 +94,10 @@ export default class Memory extends Storage {
}

async getRoles(): Role[] {
return this.items
Copy link

@ssipos90 ssipos90 Apr 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Object.values(this.items)

.reduce((filtered: Role[], item: Object) => {
const { instance } = item;
const { items } = this;
return Object.keys(items)
.reduce((filtered: Role[], itemKey: String) => {
const { instance } = items[itemKey];

if (instance instanceof Role) {
filtered.push(instance);
Expand All @@ -107,9 +108,10 @@ export default class Memory extends Storage {
}

async getPermissions(): Permission[] {
return this.items
Copy link

@ssipos90 ssipos90 Apr 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Object.values(this.items)

.reduce((filtered: Permission[], item: Object) => {
const { instance } = item;
const { items } = this;
return Object.keys(items)
.reduce((filtered: Permission[], itemKey: String) => {
const { instance } = items[itemKey];

if (instance instanceof Permission) {
filtered.push(instance);
Expand Down