Update Memory.js #47
Open
Update Memory.js #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getRoles和getPermissions方法获取数据的方式有问题 this.items 是Object 而不是 Array 需要通过Object.keys(this.items).forEach
ssipos90
suggested changes
Apr 3, 2019
ssipos90
left a comment
ssipos90
left a comment
There was a problem hiding this comment.
It's simpler if you just use Object.values instead of iterating the keys.
| } | ||
|
|
||
| async getRoles(): Role[] { | ||
| return this.items |
| } | ||
|
|
||
| async getPermissions(): Permission[] { | ||
| return this.items |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getRoles和getPermissions方法获取数据的方式有问题
this.items 是Object 而不是 Array
需要通过Object.keys(this.items).forEach