Skip to content

Septidon compatibility#16

Merged
noel2004 merged 4 commits intomainfrom
septidon-integration-compat
Mar 23, 2023
Merged

Septidon compatibility#16
noel2004 merged 4 commits intomainfrom
septidon-integration-compat

Conversation

@naure
Copy link
Contributor

@naure naure commented Mar 21, 2023

Follow-up to #14 based on @noel2004’s suggestions.

Usage

The implementation of the new shorter permutation is now selected by a feature short like so in Cargo.toml:

poseidon-circuit = { git = "https://github.com/scroll-tech/poseidon-circuit.git", features = ["short"] }

Changes:

  • Backward compatibility of the types PoseidonHashConfig and PoseidonHashChip.
  • Renamed the generic types to SpongeConfig and SpongeChip.
  • Moved the septidon module as a sibling of the old implementation.
  • Minimized item visibilities.
  • Removed unused constants attributes.
  • Moved the spec into the spec folder.

@naure naure requested a review from noel2004 March 21, 2023 15:01
@naure naure force-pushed the septidon-integration-compat branch from e99f89b to 73d47f8 Compare March 21, 2023 15:10
@naure naure mentioned this pull request Mar 21, 2023
Copy link
Member

@noel2004 noel2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. The code is backward compatible now

@noel2004 noel2004 merged commit 5a8b2cf into main Mar 23, 2023
@naure naure deleted the septidon-integration-compat branch March 23, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants