Conversation
added 6 commits
January 30, 2023 21:06
cbca71d to
a884e9c
Compare
noel2004
approved these changes
Mar 20, 2023
Member
noel2004
left a comment
There was a problem hiding this comment.
-
I guess we can reorganize some modules, for example: pick some
Specrelatied struct likeP128Pow5T3out ofposeidonmodule to avoid an explicit exposing some of them. Or just put the whole module ofseptidonunderposeidonsince both it andpow5have implied aPermuteChiptrait. -
It should be noted that the new PR has broken the code in zkevm-circuit and mpt which use
PoseidonHashConfigandPoseidonHashChip. What about making an additional wrapping for these structures and use a feature to select the preferred permute chip?
Member
|
Again I would merge first so #13 can process. Later we should try to resolve the cmpability. |
Merged
Contributor
Author
|
Thanks for the review! I have applied your suggestions in #16 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate the septuple implementation of the permutation with the sponge/lookup circuit.
The original implementation with double rounds is still supported. The same tests run with both implementations. The implementation of the new shorter permutation is selected by a feature
shortlike so inCargo.toml:This is built on top of #12. It might be easier to review the new chip in #12, then review the integration here (#14).