Skip to content

Conversation

@eirikurj
Copy link
Contributor

Purpose

Per title. This is a continuation of #18.

Closes #17.

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run ruff check and ruff format to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eirikurj
Copy link
Contributor Author

@DavidAnderegg can you approve and merge this one. Will make a new to main once done.

@DavidAnderegg DavidAnderegg merged commit 3eed319 into dev Nov 25, 2025
1 of 2 checks passed
@DavidAnderegg DavidAnderegg deleted the feature-mypy branch November 25, 2025 14:20
@eirikurj eirikurj mentioned this pull request Nov 25, 2025
13 tasks
DavidAnderegg pushed a commit that referenced this pull request Nov 25, 2025
* Workflow for merge protection for specific named branches (#19)

* Adding mypy as an option to run (#21)

* adding mypy as an option to run

* updates to input params

* do not create a report

* update call

---------

Co-authored-by: Andrew Lamkin <25615947+lamkina@users.noreply.github.com>
eirikurj added a commit that referenced this pull request Dec 3, 2025
* Workflow for merge protection for specific named branches (#19)

* Adding mypy as an option to run (#21)

* adding mypy as an option to run

* updates to input params

* do not create a report

* update call

* installing requirements.txt if present locally

* fix typo

---------

Co-authored-by: Andrew Lamkin <25615947+lamkina@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants