Skip to content

Conversation

@eirikurj
Copy link
Contributor

Purpose

Per title. See #19 and #21 for details.

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run ruff check and ruff format to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

lamkina and others added 2 commits November 21, 2025 15:06
* adding mypy as an option to run

* updates to input params

* do not create a report

* update call
@eirikurj eirikurj changed the title Add branch protection and mypy to Add branch protection and mypy check Nov 25, 2025
@DavidAnderegg
Copy link

DavidAnderegg commented Nov 25, 2025

Hi @eirikurj

Can you remind me why we need client- branches? I think we concluded in one of the dev meetings this would lead to 'code duplication' but on the github level.

Answer (in teams):
I think we still want to use them sparingly. I think last time Andew wanted to have client branches as staging branches for the images since there may be multiple features. We can discuss again.

-> Will approve for the sake of progress but should discuss it further.

Copy link

@DavidAnderegg DavidAnderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@DavidAnderegg DavidAnderegg merged commit 7d5b6fa into main Nov 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants