Skip to content

Conversation

@lamkina
Copy link
Contributor

@lamkina lamkina commented Nov 20, 2025

Purpose

This PR creates a workflow that prevents pull requests from branches with incorrect naming patterns. This workflow protects the main, dev, and client branches from diverging away from convention.

Expected time until merged

1 week

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run ruff check and ruff format to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@lamkina lamkina requested review from eirikurj and sseraj November 20, 2025 22:39
@lamkina lamkina changed the base branch from main to dev November 20, 2025 22:42
@lamkina
Copy link
Contributor Author

lamkina commented Nov 20, 2025

I tested this workflow by initially pulling to main from my feature branch and it failed the checks as expected. Then I changed to a PR to the dev branch and it passed the checks.

Copy link

@sseraj sseraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@lamkina lamkina merged commit 026c8a4 into dev Nov 21, 2025
1 of 2 checks passed
@lamkina lamkina deleted the feature-branch_name_check branch November 21, 2025 23:06
@eirikurj eirikurj mentioned this pull request Nov 25, 2025
13 tasks
DavidAnderegg pushed a commit that referenced this pull request Nov 25, 2025
* Workflow for merge protection for specific named branches (#19)

* Adding mypy as an option to run (#21)

* adding mypy as an option to run

* updates to input params

* do not create a report

* update call

---------

Co-authored-by: Andrew Lamkin <25615947+lamkina@users.noreply.github.com>
eirikurj added a commit that referenced this pull request Dec 3, 2025
* Workflow for merge protection for specific named branches (#19)

* Adding mypy as an option to run (#21)

* adding mypy as an option to run

* updates to input params

* do not create a report

* update call

* installing requirements.txt if present locally

* fix typo

---------

Co-authored-by: Andrew Lamkin <25615947+lamkina@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants