Skip to content

Conversation

@eirikurj
Copy link
Contributor

Purpose

Per title.

Closes #17.

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run ruff check and ruff format to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eirikurj eirikurj requested review from lamkina and sseraj November 13, 2025 16:50
Copy link

@sseraj sseraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just one comment

@eirikurj eirikurj requested a review from sseraj November 24, 2025 09:44
Copy link

@DavidAnderegg DavidAnderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I think we need to have a slightly different way to run mypy

@lamkina
Copy link
Contributor

lamkina commented Nov 24, 2025

Can we move the base ref branch to dev? This should be a PR to dev first, then we can move it to main and tag.

Copy link

@DavidAnderegg DavidAnderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its ok for me.

@eirikurj
Copy link
Contributor Author

@lamkina sure I can do that. The reason why this PR is to main is that it was made before settled on the feature->dev->main. Will close this one and make a new one.

@eirikurj eirikurj closed this Nov 25, 2025
@eirikurj eirikurj mentioned this pull request Nov 25, 2025
13 tasks
@DavidAnderegg DavidAnderegg deleted the feature-mypy branch November 25, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add mypy to Azure as a check

5 participants