-
Notifications
You must be signed in to change notification settings - Fork 0
Adding mypy as an option to run #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sseraj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, just one comment
DavidAnderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I think we need to have a slightly different way to run mypy
|
Can we move the base ref branch to |
DavidAnderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its ok for me.
|
@lamkina sure I can do that. The reason why this PR is to main is that it was made before settled on the feature->dev->main. Will close this one and make a new one. |
Purpose
Per title.
Closes #17.
Expected time until merged
Type of change
Testing
Checklist
ruff checkandruff formatto make sure the Python code adheres to PEP-8 and is consistently formattedfprettifyor C/C++ code withclang-formatas applicable