Skip to content

Security: Hardcoded default database credentials in production config #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nam0101 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Security: Hardcoded default database credentials in production config #221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions backend/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@ def _check_secret_key():
# Database Configuration
DB_HOST = os.environ.get('DB_HOST', 'warrackerdb')
DB_NAME = os.environ.get('DB_NAME', 'warranty_db')
DB_USER = os.environ.get('DB_USER', 'warranty_user')
DB_PASSWORD = os.environ.get('DB_PASSWORD', 'warranty_password')
DB_ADMIN_USER = os.environ.get('DB_ADMIN_USER', 'warracker_admin')
DB_ADMIN_PASSWORD = os.environ.get('DB_ADMIN_PASSWORD', 'change_this_password_in_production')
DB_USER = os.environ.get('DB_USER')
DB_PASSWORD = os.environ.get('DB_PASSWORD')
DB_ADMIN_USER = os.environ.get('DB_ADMIN_USER')
DB_ADMIN_PASSWORD = os.environ.get('DB_ADMIN_PASSWORD')

# File Upload Configuration
UPLOAD_FOLDER = os.environ.get('UPLOAD_FOLDER', '/data/uploads')
Expand Down Expand Up @@ -118,6 +118,13 @@ class ProductionConfig(Config):

@staticmethod
def init_app(app):
missing_db_vars = [
var for var in ('DB_USER', 'DB_PASSWORD', 'DB_ADMIN_USER', 'DB_ADMIN_PASSWORD')
if not app.config.get(var)
]
if missing_db_vars:
raise RuntimeError(f"Missing required database environment variables: {', '.join(missing_db_vars)}")

Config.init_app(app)
logger.info("Production configuration loaded")

Expand Down