Security: Hardcoded default database credentials in production config#221
Open
Nam0101 wants to merge 1 commit intosassanix:mainfrom
Open
Conversation
…onfig The config includes usable default credentials (`DB_USER='warranty_user'`, `DB_PASSWORD='warranty_password'`, `DB_ADMIN_USER='warracker_admin'`, `DB_ADMIN_PASSWORD='change_this_password_in_production'`). In real deployments, missing env vars will silently activate these predictable credentials, allowing unauthorized DB access if the database is reachable. Affected files: config.py Signed-off-by: Nguyen Van Nam <nam.nv205106@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there! 👋
While going through the codebase, I noticed a minor opportunity for improvement regarding
backend/config.py.Context:
The config includes usable default credentials (
DB_USER='warranty_user',DB_PASSWORD='warranty_password',DB_ADMIN_USER='warracker_admin',DB_ADMIN_PASSWORD='change_this_password_in_production'). In real deployments, missing env vars will silently activate these predictable credentials, allowing unauthorized DB access if the database is reachable.Proposed fix:
Remove credential defaults and require environment variables at startup. Example:
DB_PASSWORD = os.environ["DB_PASSWORD"](same for admin creds), and raise a clear startup error if unset. If local development needs defaults, isolate them in a dedicated non-production config class not used in Docker/CI/prod.Files touched:
backend/config.py(modified)(Note: Tested the changes locally to ensure everything works as expected. Let me know if you need any adjustments, happy to help!)
—
NamNV
📍 Hanoi, Vietnam
📧 nam.nv205106@gmail.com