Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The most important thing I want to fix is the container used for samtools. I noticed it was staphb/samtools:1.22.1 for a few modules, all patched from nf-core. Perhaps there was no biocontainer at the time ?
We have to favour standard containers built on BioConda: first biocontainers, and falling back to Seqera containers.
nf-core modules all use biocontainers/samtools:1.22.1 so I've decided to update those, and whilst at it, I updated all modules.
After this, only 2
.difffiles remain.The
testprofile runs fine. Thetest_fullprofile should complete this morning.I had to modify a few sub-workflows to not gather the
versionschannel, including one from sanger-tol I believe. I thinknf-core lintmay complain. I'll double-check and may open a PR in sanger-tol/nf-core-modulesPR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).