Skip to content

Conversation

@muffato
Copy link
Member

@muffato muffato commented Jan 20, 2026

Hi,

The most important thing I want to fix is the container used for samtools. I noticed it was staphb/samtools:1.22.1 for a few modules, all patched from nf-core. Perhaps there was no biocontainer at the time ?
We have to favour standard containers built on BioConda: first biocontainers, and falling back to Seqera containers.
nf-core modules all use biocontainers/samtools:1.22.1 so I've decided to update those, and whilst at it, I updated all modules.

After this, only 2 .diff files remain.

The test profile runs fine. The test_full profile should complete this morning.

I had to modify a few sub-workflows to not gather the versions channel, including one from sanger-tol I believe. I think nf-core lint may complain. I'll double-check and may open a PR in sanger-tol/nf-core-modules

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@muffato muffato requested a review from sainsachiko January 20, 2026 09:33
@muffato muffato self-assigned this Jan 20, 2026
Copy link

@sainsachiko sainsachiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look fine to me, assuming all the test pass.

@muffato
Copy link
Member Author

muffato commented Jan 20, 2026

All tests passed

@muffato muffato merged commit 2bb47fb into dev Jan 20, 2026
21 of 26 checks passed
@muffato muffato deleted the samtools branch January 20, 2026 14:26
@muffato muffato linked an issue Jan 20, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants