Skip to content

Manage DNF modules #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kartnico wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Manage DNF modules #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion pillar.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,11 @@ remi:
remi:
disabled: True
remi-php70:
disabled: False
disabled: False

module:
glpi:
disabled: True
php:
disabled: False
version: remi-7.4
24 changes: 24 additions & 0 deletions remi/init.sls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,4 +77,28 @@ enable_{{ repo }}:
{% endfor %}
{% endif %}

{% if 'module' in remi_settings %}
{% for module,opts in remi_settings.module.items() %}
{% if opts.disabled|default(False) %}
disable_module_{{ module }}:
cmd.run:
- name: dnf -y module disable {{ module }}{% if opts.version|default(False) %}:{{ opts.version }}{% endif %}
- unless: dnf module --disabled list {{ module }}{% if opts.version|default(False) %}:{{ opts.version }}{% endif %}
{% else %}
reset_module_{{ module }}:
cmd.run:
- name: dnf -y module reset {{ module }}
- onlyif: dnf module --enabled list {{ module }}
{% if opts.version|default(False) %}
- unless: dnf module --enabled list {{ module }}:{{ opts.version }}
{% endif %}

enable_module_{{ module }}:
cmd.run:
- name: dnf -y module enable {{ module }}{% if opts.version|default(False) %}:{{ opts.version }}{% endif %}
- unless: dnf module --enabled list {{ module }}{% if opts.version|default(False) %}:{{ opts.version }}{% endif %}
{% endif %}
{% endfor %}
{% endif %}
Comment on lines +80 to +102
Copy link
Copy Markdown
Contributor

@myii myii Aug 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make this a little easier to follow, would you mind applying the following indentation, or something similar?

Suggested change
{% if 'module' in remi_settings %}
{% for module,opts in remi_settings.module.items() %}
{% if opts.disabled|default(False) %}
disable_module_{{ module }}:
cmd.run:
- name: dnf -y module disable {{ module }}{% if opts.version|default(False) %}:{{ opts.version }}{% endif %}
- unless: dnf module --disabled list {{ module }}{% if opts.version|default(False) %}:{{ opts.version }}{% endif %}
{% else %}
reset_module_{{ module }}:
cmd.run:
- name: dnf -y module reset {{ module }}
- onlyif: dnf module --enabled list {{ module }}
{% if opts.version|default(False) %}
- unless: dnf module --enabled list {{ module }}:{{ opts.version }}
{% endif %}
enable_module_{{ module }}:
cmd.run:
- name: dnf -y module enable {{ module }}{% if opts.version|default(False) %}:{{ opts.version }}{% endif %}
- unless: dnf module --enabled list {{ module }}{% if opts.version|default(False) %}:{{ opts.version }}{% endif %}
{% endif %}
{% endfor %}
{% endif %}
{% if 'module' in remi_settings %}
{% for module,opts in remi_settings.module.items() %}
{% if opts.disabled|default(False) %}
disable_module_{{ module }}:
cmd.run:
- name: dnf -y module disable {{ module }}{% if opts.version|default(False) %}:{{ opts.version }}{% endif %}
- unless: dnf module --disabled list {{ module }}{% if opts.version|default(False) %}:{{ opts.version }}{% endif %}
{% else %}
reset_module_{{ module }}:
cmd.run:
- name: dnf -y module reset {{ module }}
- onlyif: dnf module --enabled list {{ module }}
{% if opts.version|default(False) %}
- unless: dnf module --enabled list {{ module }}:{{ opts.version }}
{% endif %}
enable_module_{{ module }}:
cmd.run:
- name: dnf -y module enable {{ module }}{% if opts.version|default(False) %}:{{ opts.version }}{% endif %}
- unless: dnf module --enabled list {{ module }}{% if opts.version|default(False) %}:{{ opts.version }}{% endif %}
{% endif %}
{% endfor %}
{% endif %}


{% endif %}