Skip to content

Manage DNF modules#14

Open
kartnico wants to merge 1 commit intosaltstack-formulas:masterfrom
kartzone1:manage_modules
Open

Manage DNF modules#14
kartnico wants to merge 1 commit intosaltstack-formulas:masterfrom
kartzone1:manage_modules

Conversation

@kartnico
Copy link
Copy Markdown

@kartnico kartnico commented Aug 17, 2020

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Manage DNF modules

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Close #13

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

@pull-assistant
Copy link
Copy Markdown

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     Manage DNF modules

Powered by Pull Assistant. Last update 71314d3 ... 71314d3. Read the comment docs.

Copy link
Copy Markdown
Contributor

@myii myii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, @kartnico. Just a little suggestion, if you don't mind. Otherwise this appears good to go.

Comment on lines +80 to +102
{% if 'module' in remi_settings %}
{% for module,opts in remi_settings.module.items() %}
{% if opts.disabled|default(False) %}
disable_module_{{ module }}:
cmd.run:
- name: dnf -y module disable {{ module }}{% if opts.version|default(False) %}:{{ opts.version }}{% endif %}
- unless: dnf module --disabled list {{ module }}{% if opts.version|default(False) %}:{{ opts.version }}{% endif %}
{% else %}
reset_module_{{ module }}:
cmd.run:
- name: dnf -y module reset {{ module }}
- onlyif: dnf module --enabled list {{ module }}
{% if opts.version|default(False) %}
- unless: dnf module --enabled list {{ module }}:{{ opts.version }}
{% endif %}

enable_module_{{ module }}:
cmd.run:
- name: dnf -y module enable {{ module }}{% if opts.version|default(False) %}:{{ opts.version }}{% endif %}
- unless: dnf module --enabled list {{ module }}{% if opts.version|default(False) %}:{{ opts.version }}{% endif %}
{% endif %}
{% endfor %}
{% endif %}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make this a little easier to follow, would you mind applying the following indentation, or something similar?

Suggested change
{% if 'module' in remi_settings %}
{% for module,opts in remi_settings.module.items() %}
{% if opts.disabled|default(False) %}
disable_module_{{ module }}:
cmd.run:
- name: dnf -y module disable {{ module }}{% if opts.version|default(False) %}:{{ opts.version }}{% endif %}
- unless: dnf module --disabled list {{ module }}{% if opts.version|default(False) %}:{{ opts.version }}{% endif %}
{% else %}
reset_module_{{ module }}:
cmd.run:
- name: dnf -y module reset {{ module }}
- onlyif: dnf module --enabled list {{ module }}
{% if opts.version|default(False) %}
- unless: dnf module --enabled list {{ module }}:{{ opts.version }}
{% endif %}
enable_module_{{ module }}:
cmd.run:
- name: dnf -y module enable {{ module }}{% if opts.version|default(False) %}:{{ opts.version }}{% endif %}
- unless: dnf module --enabled list {{ module }}{% if opts.version|default(False) %}:{{ opts.version }}{% endif %}
{% endif %}
{% endfor %}
{% endif %}
{% if 'module' in remi_settings %}
{% for module,opts in remi_settings.module.items() %}
{% if opts.disabled|default(False) %}
disable_module_{{ module }}:
cmd.run:
- name: dnf -y module disable {{ module }}{% if opts.version|default(False) %}:{{ opts.version }}{% endif %}
- unless: dnf module --disabled list {{ module }}{% if opts.version|default(False) %}:{{ opts.version }}{% endif %}
{% else %}
reset_module_{{ module }}:
cmd.run:
- name: dnf -y module reset {{ module }}
- onlyif: dnf module --enabled list {{ module }}
{% if opts.version|default(False) %}
- unless: dnf module --enabled list {{ module }}:{{ opts.version }}
{% endif %}
enable_module_{{ module }}:
cmd.run:
- name: dnf -y module enable {{ module }}{% if opts.version|default(False) %}:{{ opts.version }}{% endif %}
- unless: dnf module --enabled list {{ module }}{% if opts.version|default(False) %}:{{ opts.version }}{% endif %}
{% endif %}
{% endfor %}
{% endif %}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] dnf modules compatibility

2 participants