Skip to content

Use hash for temporary files #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cprodescu wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use hash for temporary files #43

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f64b3b0
Hash temporary file names.
Mar 18, 2017
4aa1d2f
Ensure temporary file names hashes do not have collisions.
Mar 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion GlobalizeCompilerHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
var crypto = require("crypto");
var fs = require("fs");
var globalizeCompiler = require("globalize-compiler");
var path = require("path");
Expand Down Expand Up @@ -39,8 +40,30 @@ GlobalizeCompilerHelper.prototype.createCompiledDataModule = function(request) {
return filepath;
};

var _tmpFilesMap = {};
function assertUniqueTmpfile(filepath, tmpfile) {
if (_tmpFilesMap[tmpfile] != null) {
if (_tmpFilesMap[tmpfile] != filepath) {
throw new Error(
"Multiple files map to temporary file \"" + tmpfile + "\":\n" +
[_tmpFilesMap[tmpfile], filepath].join('\n')
);
}
} else {
_tmpFilesMap[tmpfile] = filepath;
}
}

GlobalizeCompilerHelper.prototype.getModuleFilepath = function(request) {
return path.join(this.tmpdir, request.replace(/.*!/, "").replace(/[\/\\?" :]/g, "-"));
var filepath = request.replace(/.*!/, "");
var tmpfile = crypto
.createHash("sha1")
.update(filepath, "utf8")
.digest("hex") + ".js";

assertUniqueTmpfile(filepath, tmpfile);

return path.join(this.tmpdir, tmpfile);
};

GlobalizeCompilerHelper.prototype.compile = function(locale, request) {
Expand Down