Use hash for temporary files#43
Open
cprodescu wants to merge 2 commits intorxaviers:masterfrom
cprodescu:fix-42-tmp-file-paths
Open
Use hash for temporary files#43cprodescu wants to merge 2 commits intorxaviers:masterfrom cprodescu:fix-42-tmp-file-paths
cprodescu wants to merge 2 commits intorxaviers:masterfrom
cprodescu:fix-42-tmp-file-paths
Conversation
added 2 commits
March 18, 2017 15:37
Current encoding transforms the file path from where the Globalize calls were extracted into a file name. In deeply nested projects, this can double the length of the path, causing E_NAMETOOLONG issues. Before this: /long/path/to/project/.tmp-globalize-webpack/-long-path-to-project-src-component-foo-index.js After this: /long/path/to/project/.tmp-globalize-webpack/5b4c40dd44a2cfde54a3e04cd183aa70edd64c1a.js This has the downside that it makes the content of the files more opaque, being harder to debug which content maps to which file. One would have to ``` echo -n `readlink -f src/component/foo/index.js` | shasum ``` This fixes #42 and #16.
Owner
|
@cprodescu thank you for your PR... I am wondering what we could do to allow this to be done on user land? I mean, I'm wondering if we could expose a plugin option that takes a function, that in turn takes one argument: the filename; and return the processed filename. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hash temporary file names.
Current encoding transforms the file path from where the Globalize calls
were extracted into a file name. In deeply nested projects, this can
double the length of the path, causing E_NAMETOOLONG issues.
Before this:
/long/path/to/project/.tmp-globalize-webpack/-long-path-to-project-src-component-foo-index.js
After this:
/long/path/to/project/.tmp-globalize-webpack/5b4c40dd44a2cfde54a3e04cd183aa70edd64c1a.js
This has the downside that it makes the content of the files more opaque, being
harder to debug which content maps to which file. One would have to
Fixes #42 and #16.