Open
Conversation
albertz
reviewed
Feb 17, 2022
| if self.darc1: | ||
| c += self.darc1 * self.get_darc1() | ||
| if c is 0: | ||
| if c == 0: |
Member
There was a problem hiding this comment.
This is wrong in case c is a tf.Tensor or numpy.ndarray.
Same also for all the other changes.
albertz
requested changes
Feb 17, 2022
Member
albertz
left a comment
There was a problem hiding this comment.
It's not as simple (that's why I did not do it yet).
Basically you need isinstance(c, (int, float, numpy.number)) or so.
Contributor
Author
I see. It seems that all tests pass though, so it's maybe difficult to tell what would be correct and doesn't break any setups, right? |
Member
|
But still it should be done like that. This just shows that the tests don't cover this. I wonder actually, I thought e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running RETURNN, I get
I don't see a reason to do it the way it is currently done, so we could just fix it like proposed here.