Bump required Python 3.7 -> 3.8, drop TF1 support#1668
Conversation
|
By dropping support for 3.7 we also drop support for TF1. It is my understanding that some folks might still be using TF1.x for some of their experiments. However, these experiments are probably also using ancient RETURNN versions, so I believe it's ok to drop support. @albertz WDYT? |
This comment was marked as resolved.
This comment was marked as resolved.
c925691 to
960c31f
Compare
Markdown is easier to edit for many folks as it has broader usage outside the python docs ecosystem.
This reverts commit c00d1f5.
ee09976 to
2f242b2
Compare
Why? |
TF1 never supported Python > 3.7. See the CI log. There are no pip packages available for TF1 for 3.8 and onwards. |
|
Please check with @curufinwe if dropping TF1 is ok. |
README.rst
Outdated
| Dependencies | ||
| ============ | ||
|
|
||
| pip dependencies are listed in ``requirements.txt`` and ``requirements-dev``, although some parts of the code may require additional dependencies (e.g. ``librosa``, ``resampy``) on-demand. |
There was a problem hiding this comment.
| pip dependencies are listed in ``requirements.txt`` and ``requirements-dev``, although some parts of the code may require additional dependencies (e.g. ``librosa``, ``resampy``) on-demand. | |
| Pip dependencies are listed in ``requirements.txt`` and ``requirements-dev``, | |
| although some parts of the code may require additional dependencies (e.g. ``librosa``, ``resampy``) on-demand. | |
| For TensorFlow-based setups, RETURNN requires TF >=2. | |
| For PyTorch-based setups, RETURNN requires Torch >=1. |
(I actually don't really know our min required Torch version... But this here would be some good starting point.)
|
In the failing test, can you filter out |
|
Ah, in the failing test checking the stdout, the |
Closes #1326
Opening this to run CI and such.