Open
Conversation
Atticus1806
requested review from
JackTemaki,
christophmluscher,
michelwi and
vieting
Contributor
|
@christophmluscher is it possible to get the modifications to the Systems in smaller PRs? This is sheer impossible to review. |
Contributor
|
After an offline discussion with @Atticus1806 , given that the setup changes are breaking existing setups and possibly need multiple weeks/months of review for a rather deprecated pipeline, I will do a local copy of |
Atticus1806
force-pushed
the
bene_tedlium_hybrid_baseline
branch
from
b870355 to
8c9a3d8
Compare
This was referenced Sep 13, 2023
Closed
Contributor
Marvin84
reviewed
Jan 22, 2024
| from .nn_config.nn_args import get_nn_args | ||
|
|
||
|
|
||
| def run_gmm_system(): |
Contributor
There was a problem hiding this comment.
Is the FSA bug correction included?
Contributor
Author
There was a problem hiding this comment.
I am not sure. Where / how would that be included? RASR version?
Contributor
There was a problem hiding this comment.
now it should be
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.