Add alignment alias and step, more state tying dumping#173
Closed
Atticus1806 wants to merge 2 commits intomainfrom
Closed
Add alignment alias and step, more state tying dumping#173Atticus1806 wants to merge 2 commits intomainfrom
Atticus1806 wants to merge 2 commits intomainfrom
Conversation
Atticus1806
requested review from
JackTemaki,
christophmluscher,
michelwi and
vieting
JackTemaki
reviewed
Sep 18, 2023
| **step_args.sdm_args, | ||
| ) | ||
|
|
||
| def run_forced_align_step(self, step_args): |
Contributor
There was a problem hiding this comment.
I wonder if it would be cleaner to add this as _v2 and the old one as run_forced_align_step. Otherwise it is extremely unclear why it does not match.
Contributor
|
I will replace this with another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prequesite for #151
Adds an alias to the dump alignment jobs, adds a new method for forced align and state tying dump for the final state tying.