Cstring escapes

[johnyb]

This should fix #2. Please don't merge, yet, still working on this branch. Just wanted to publish, what I already got.

ToDo

• cherry-pick Unescape all C-string escape sequences mikejholly/node-po#3
• handle \n when writing
• add more tests for Unescape all C-string escape sequences mikejholly/node-po#3
• implement reverse of c-string escapes for Item.toString (\n already done)

[rubenv]

Cool, let me know when it's ready to merge.

[johnyb]

also rebased to latest master

[johnyb]

Ready to merge, once travis is green. Also fixes #2.

[johnyb]

I tried to comment my research in the code and hope it's understandable. I mostly tested how msgcat from gettext tools behaves and adjusted the tests accordingly. Then I changed implementation until tests were green.

Anyway, when releasing this, you might want to bump this as "incompatible", since handling of \n in msgid changed. It now works like xgettext would work.

[johnyb]

One more thing to add:

Parsing this po code

msgid ""
"something\n"
"else"
msgstr ""

msgid ""
"something"
"else"
msgstr ""

and writing it to a file, would produce an invalid po file with v0.2.11 and earlier. This PR would fix this issue, so this might indeed be considered a bugfix. d8fc514 contains the fix.

[rubenv]

Oh darn, I missed this. This is still relevant, right?

Code looks good to me, can be merged unless you have a reason why it shouldn't be.

[johnyb]

Ahh, missed that myself, too :) Yes, IMHO this should still be in master and released as bugfix.

[rubenv]

Nod. Rolling out release.

[rubenv]

Released to NPM as 0.2.12.

Thanks!