Merged
Conversation
aramirezreyes
force-pushed
the
print-conflicting-name
branch
from
71f5687 to
5b1cade
Compare
aramirezreyes
force-pushed
the
print-conflicting-name
branch
from
5b1cade to
528038a
Compare
aramirezreyes
force-pushed
the
print-conflicting-name
branch
from
528038a to
db4d9f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
I added two tests: the first one tests that importing a conflicting name errors (satisfied by the current behavior, I did not find a current test for this) and the second checks that the error message contains the conflicting name.
This would fix close #96