[Feature request] Show conflicting name on error

[aramirezreyes]

Would it be possible to print the name of the conflicting name when erroring?

I found myself commenting bits of an import::from call to try and discover which name was conflicting. I think this would be useful.

Could be added by modifying this line.

import/R/safe_assign.R

Lines 19 to 20 in 8649e70

	stop("Cannot assign name to different value in the given environment. Name already in use.",
	call. = FALSE)

Would it be desirable? If so, I would be happy to make a pull request.

[torfason]

Yes, that sounds like a simple and very useful addition. I would be happy to merge a pull request for this. I just moved the discussion about the development process and governance from an issue to the discussions (pinned at the top):

• https://github.com/rticulate/import/discussions
  • On development process and governance #97

In particular, it would be good to have two commits, first commit with a test that fails on current behavior but passes with the fix, and the second comment the fix itself. I think there is no need to document this, so the third documentation comment can be ignored/omitted.

I took the liberty to assign this to you @aramirezreyes :-)

[aramirezreyes]

Closed as completed by #98. Thanks @torfason for the guidance!

[torfason]

Much appreciated, thanks for a clean and well-structured PR!

This fix has been merged into main and can be installed using:

• pak::pak("rticulate/import")

I'll leave the issue open with tag fixed-in-main to remind myself that there are changes unreleased to CRAN.

😊🙏