Use helmignore for test directories

.github/workflows/chart-doc.yaml

@@ -16,9 +16,7 @@ jobs:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Set up Helm
-        uses: azure/setup-helm@v4.2.0
-        with:
-          version: v3.6.3
+        uses: azure/setup-helm@v4
 
       - name: install Just
         uses: extractions/setup-just@v2
@@ -78,9 +76,7 @@ jobs:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Set up Helm
-        uses: azure/setup-helm@v4.2.0
-        with:
-          version: v3.6.3
+        uses: azure/setup-helm@v4
 
       - name: Add rstudio helm repo
         run: helm repo add rstudio https://helm.rstudio.com

.github/workflows/chart-rebuild.yaml

@@ -13,9 +13,7 @@ jobs:
           fetch-depth: 0
 
       - name: Set up Helm
-        uses: azure/setup-helm@v4.2.0
-        with:
-          version: v3.6.3
+        uses: azure/setup-helm@v4
 
       - name: Add rstudio helm repo
         run: helm repo add rstudio https://helm.rstudio.com

.github/workflows/chart-releaser.yaml

@@ -20,9 +20,7 @@ jobs:
           git config user.email "$GITHUB_ACTOR@users.noreply.github.com"
 
       - name: Install Helm
-        uses: azure/setup-helm@v4.2.0
-        with:
-          version: v3.6.3
+        uses: azure/setup-helm@v4
 
       - name: Add rstudio helm repo
         run: helm repo add rstudio https://helm.rstudio.com

.github/workflows/chart-test.yaml

@@ -16,9 +16,7 @@ jobs:
           fetch-depth: 0
 
       - name: Set up Helm
-        uses: azure/setup-helm@v4.2.0
-        with:
-          version: v3.6.3
+        uses: azure/setup-helm@v4
 
       - name: Add rstudio helm repo
         run: helm repo add rstudio https://helm.rstudio.com
@@ -28,28 +26,20 @@ jobs:
           python-version: "3.10"
 
       - name: Set up chart-testing
-        uses: helm/chart-testing-action@v2.6.1
-
-      - name: Symlink ci-lint -> ci
-        run: |
-          for dir in ci/*/lint; do
-            dir=${dir#ci/}
-            dir=${dir%/lint}
-            ln -s ../../ci/${dir}/lint charts/${dir}/ci
-          done
+        uses: helm/chart-testing-action@v2
 
       - name: Run chart-testing (list-changed)
         id: list-changed
         run: |
-          changed=$(ct list-changed --target-branch main --chart-dirs charts --chart-dirs other-charts)
+          changed=$(ct list-changed --use-helmignore --target-branch main --chart-dirs charts --chart-dirs other-charts)
           if [[ -n "$changed" ]]; then
             echo 'changed=true' >> $GITHUB_OUTPUT
           fi
 
       - name: Run chart-testing (lint changed)
         id: ct-lint
         if: steps.list-changed.outputs.changed == 'true'
-        run: ct lint --target-branch main --chart-dirs charts --chart-dirs other-charts
+        run: ct lint --use-helmignore --target-branch main --chart-dirs charts --chart-dirs other-charts
         continue-on-error: true
 
       - name: Run chart-testing (lint all)
@@ -91,20 +81,10 @@ jobs:
           fetch-depth: 0
 
       - name: Set up Helm
-        uses: azure/setup-helm@v4.2.0
-        with:
-          version: v3.6.3
+        uses: azure/setup-helm@v4
 
       - name: Install helm unittest plugin
-        run: helm plugin install --version v0.6.3  https://github.com/helm-unittest/helm-unittest.git
-
-      - name: Symlink ci-tests -> tests
-        run: |
-          for dir in ci/*/tests; do
-            dir=${dir#ci/}
-            dir=${dir%/tests}
-            ln -s ../../ci/${dir}/tests charts/${dir}/tests
-          done
+        run: helm plugin install https://github.com/helm-unittest/helm-unittest.git
 
       - name: Run chart unit tests
         id: unittest
@@ -149,9 +129,7 @@ jobs:
           fetch-depth: 0
 
       - name: Set up Helm
-        uses: azure/setup-helm@v4.2.0
-        with:
-          version: v3.6.3
+        uses: azure/setup-helm@v4
 
       - name: Add rstudio helm repo
         run: helm repo add rstudio https://helm.rstudio.com
@@ -161,26 +139,18 @@ jobs:
           python-version: "3.10"
 
       - name: Set up chart-testing
-        uses: helm/chart-testing-action@v2.6.1
-
-      - name: Symlink ci-install -> ci
-        run: |
-          for dir in ci/*/install; do
-            dir=${dir#ci/}
-            dir=${dir%/install}
-            ln -s ../../ci/${dir}/install charts/${dir}/ci
-          done
+        uses: helm/chart-testing-action@v2
 
       - name: Run chart-testing (list-changed)
         id: list-changed
         run: |
-          changed=$(ct list-changed --target-branch main --chart-dirs charts --chart-dirs other-charts)
+          changed=$(ct list-changed --use-helmignore --target-branch main --chart-dirs charts --chart-dirs other-charts)
           if [[ -n "$changed" ]]; then
             echo 'changed=true' >> $GITHUB_OUTPUT
           fi
 
       - name: Create kind cluster
-        uses: helm/kind-action@v1.10.0
+        uses: helm/kind-action@v1
 
       - name: Install SealedSecrets Helm Chart
         run: |
@@ -249,9 +219,7 @@ jobs:
           fetch-depth: 0
 
       - name: Set up Helm
-        uses: azure/setup-helm@v4.2.0
-        with:
-          version: v3.6.3
+        uses: azure/setup-helm@v4
 
       - uses: extractions/setup-just@v2
 

.gitignore

@@ -15,3 +15,5 @@ _publish.yml
 
 /.quarto/
 
+# helm packages
+*.tgz

charts/posit-chronicle/.helmignore

@@ -10,6 +10,7 @@
 .hg/
 .hgignore
 .svn/
+.helmignore
 # Common backup files
 *.swp
 *.bak
@@ -23,4 +24,6 @@
 .vscode/
 
 # chart tests
+ci/
+lint/
 tests/

charts/rstudio-connect/.helmignore

@@ -10,6 +10,7 @@
 .hg/
 .hgignore
 .svn/
+.helmignore
 # Common backup files
 *.swp
 *.bak
@@ -23,4 +24,6 @@
 .vscode/
 
 # chart tests
+ci/
+lint/
 tests/

charts/rstudio-launcher-rbac/.helmignore

@@ -10,6 +10,7 @@
 .hg/
 .hgignore
 .svn/
+.helmignore
 # Common backup files
 *.swp
 *.bak
@@ -23,4 +24,6 @@
 .vscode/
 
 # chart tests
+ci/
+lint/
 tests/

charts/rstudio-library/.helmignore

@@ -10,6 +10,7 @@
 .hg/
 .hgignore
 .svn/
+.helmignore
 # Common backup files
 *.swp
 *.bak
@@ -23,4 +24,6 @@
 .vscode/
 
 # chart tests
+ci/
+lint/
 tests/

charts/rstudio-pm/.helmignore

@@ -10,6 +10,7 @@
 .hg/
 .hgignore
 .svn/
+.helmignore
 # Common backup files
 *.swp
 *.bak
@@ -23,4 +24,6 @@
 .vscode/
 
 # chart tests
+ci/
+lint/
 tests/

charts/rstudio-workbench/.helmignore

@@ -1,6 +1,9 @@
 snapshot/
 Makefile
 *.gotmpl
+.helmignore
 
 # chart tests
+ci/
+lint/
 tests/