Merged
Conversation
91326d1 to
ce27039
Compare
Contributor
Author
|
One of the installation tests is failing: The output of ---
# Source: rstudio-workbench/templates/ingress.yaml
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
name: release-name-rstudio-workbench
labels:
helm.sh/chart: rstudio-workbench-0.9.1
app.kubernetes.io/name: rstudio-workbench
app.kubernetes.io/instance: release-name
app.kubernetes.io/version: "2025.05.0"
app.kubernetes.io/managed-by: Helm
annotations:
kubernetes.io/ingress.class: traefik
spec:
rules:
- host: "workbench.rstudio.com"
http:
paths:
-
path: /test/
pathType: Prefix
backend:
service:
name: release-name-rstudio-workbench
port:
number: 80The output parses correctly with $ yq '.spec.rules[0].http.paths[0].backend.service.port.number' < ingress.yaml
80 |
Contributor
Author
|
The new chart-testing release has resolved the above issue! |
Also ignore packaged charts in .gitignore
Both chart-testing and unittest now support .helmignore
This allows us to automatically be kept up-to-date with the latest version of the action, which in turn gets us the latest version of helm and chart-testing
b8027cd to
d828218
Compare
jforest
approved these changes
Jun 3, 2025
Contributor
jforest
left a comment
There was a problem hiding this comment.
I love the cleanup! Simpler and easier to understand, thanks for taking this on!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
helm unittestandchart-testingnow support using.helmignore🙌🏻Let's move the test files back into the charts directory so that we no longer have to symlink them.