Fixed Windows scRGB screenshots + Game Brightness#14
Merged
rrtt217 merged 2 commits intorrtt217:masterfrom Feb 18, 2026
Merged
Conversation
rrtt217
requested changes
Feb 18, 2026
Owner
rrtt217
left a comment
There was a problem hiding this comment.
Omg I forgot to do that, but the condition you uses is technologically incorrect
common/src/main/java/xyz/rrtt217/HDRMod/core/PngjHDRScreenshot.java
Outdated
Show resolved
Hide resolved
Owner
|
RGBA16UNORM is only functional on PQ transfer function, and for Rec.2100 PQ no transformation is actually needed, wysiwyg. |
rrtt217
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, scRGB screenshots were incorrectly affected by Game Brightness when != 80.
(WearyOlly confirmed it's not on Linux.)
TODO: rgba16unorm
Fix: