Downgrade benign error messages to debug#107
Closed
asorbini wants to merge 2 commits intoros2:masterfrom
Closed
Conversation
Signed-off-by: Andrea Sorbini <asorbini@rti.com>
Signed-off-by: Andrea Sorbini <asorbini@rti.com>
Contributor
Author
|
Two unit tests failed with this change: I'll wait for input from the maintainers before taking any further action. |
Contributor
Author
|
I just noticed #102 which addresses the same problem. I'll close this PR and wait for that one to be merged, hopefully in time for Galactic, or for a patch soon after 🤞🏼 |
This was referenced Apr 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the severity level of two messages logged by the
get_typesupport_handle_function()functions inrosidl_typesupport_candrosidl_typesupport_cpp, from error to debug.As far as I can gather from inspecting and debugging the code, these functions are used to look up a specific type support by name, and the current "error condition" is actually just a benign case of an available type support not matching the sought after
identifier.I'm still unsure of how the condition is actually triggered, but these error messages show up at times in applications running on
rmw_connextddsand can become quite intrusive (see ros2/rmw_connextdds#21 for an example).After debugging
rmw_connextdds, I've confirmed that these errors are printed when the RMW tries to look up one of the type supports it needs (e.g. see here). The error is always printed only forrosidl_typesupport_cpp, and I haven't been able to determine why it doesn't also appear at times for other type supports, or why it doesn't happen all the time.Any input on uncovering these answers is of course welcome, but since the condition seems to be benign (even if only from empirical observation), I would like to downgrade the errors to reduce their intrusiveness.