Use rmw_qos_profile_unknown when adding entity to graph#28
Merged
Conversation
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
hidmic
approved these changes
Apr 13, 2021
ivanpauno
changed the title
Member
Author
|
CI:
|
Collaborator
|
Test results are in line with expected test failures when I'm going to merge the PR. FYI, @ivanpauno I think you can also run CI with just Connext selected if you want. The required fastrtps packages should be included even if EDIT: added link to old PR. |
delete-merged-branch
bot
deleted the
ivanpauno/use-rmw-qos-profile-unknown
branch
asorbini
pushed a commit
that referenced
this pull request
Apr 14, 2021
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the qos policies aren't shared during discovery (history).
Use
rmw_qos_profile_unknownas the base profile, so users ofrmw_get_publishers_info_by_topic(),rmw_get_subscriptions_info_by_topic()can tell which policy was correctly filled by the middleware and which not.This was already the case in fastrtps.
Cyclonedds is also sharing
historyduring discovery, so this is not an issue.We're also documenting this in ros2/rmw#308, because docs weren't clear in the past.