Conversation
…subscriptions_info_by_topic Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
jacobperron
left a comment
There was a problem hiding this comment.
LGTM
I guess some RMW implementations should probably be updated to match this documentation. In that case, this may be considered an API change and perhaps we should hold until after we branch for Galactic.
The rmw implementations already match this behavior, so this is only documentation. I don't remember if they set the policies that are not updated to |
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> Co-authored-by: William Woodall <william@osrfoundation.org>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
bc07bf9 to
10b6c6b
Compare
Fastrtps was already doing that https://github.com/ros2/rmw_fastrtps/blob/7bb3563bebd20c3cae03231c2e321bf132651449/rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/custom_participant_info.hpp#L149. I send a patch to connextdds to fix this ros2/rmw_connextdds#28. |
|
PR checker is happy, this a docs only PR so no need of more CI. |
Based on ros2/rclcpp#1626 (comment).