Explicitly set a static global git configuration while testing#58
Merged
leander-dsouza merged 3 commits intomainfrom Sep 9, 2025
Merged
Explicitly set a static global git configuration while testing#58leander-dsouza merged 3 commits intomainfrom
leander-dsouza merged 3 commits intomainfrom
Conversation
Some of the vcs2l tests have expectations that certain git configuration values are set. We should ignore any custom user configurations and explicitly set the configuration values for those variables that are assumed by the tests. Signed-off-by: Scott K Logan <logans@cottsay.net>
cottsay
requested review from
claraberendsen and
leander-dsouza
as code owners
leander-dsouza
requested changes
Sep 9, 2025
This was referenced Sep 9, 2025
Signed-off-by: Scott K Logan <logans@cottsay.net>
Member
Author
|
Thanks, addressed in 328b653. |
claraberendsen
previously approved these changes
Sep 9, 2025
Contributor
claraberendsen
left a comment
claraberendsen
left a comment
There was a problem hiding this comment.
Thanks for opening this, LGMT!
leander-dsouza
previously approved these changes
Sep 9, 2025
Member
leander-dsouza
left a comment
leander-dsouza
left a comment
There was a problem hiding this comment.
Minor nitpick regarding the configuration file, everything else looks good for merge :)
Signed-off-by: Scott K Logan <logans@cottsay.net> Co-authored-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
cottsay
dismissed stale reviews from leander-dsouza and claraberendsen
via
d74558f
leander-dsouza
approved these changes
Sep 9, 2025
Member
leander-dsouza
left a comment
leander-dsouza
left a comment
There was a problem hiding this comment.
The tests are known to be a bit flaky on Windows, so they can be ignored for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Some of the vcs2l tests have expectations that certain git configuration values are set. We should ignore any custom user configurations and explicitly set the configuration values for those variables that are assumed by the tests.
In particular, the captured expected command output doesn't account for git versions which print a hint when
defaultBranchisn't explicitly set (as part of themaster->maintransition), and there is captured output which contains abbreviated SHA values that are expected to contain 7 characters.Description of how this change was tested