Remove expected hints for shallow clone#54
Closed
leander-dsouza wants to merge 2 commits intomainfrom
Closed
Conversation
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
b7484b7 to
61cc2e3
Compare
f5c60a9 to
6fcd3c8
Compare
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
6fcd3c8 to
2f191be
Compare
Member
Author
|
Closing this PR in favour of #58. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Adjusted the expected value of shallow clone to remove
hints:before comparing with output.This is seen in newer versions of git, where the following message is printed:
This is motivated by Add Codecov testing workflow #53, as the disabling of the below messages is not possible when using a custom image with ros-infrastructure/ci/.github/workflows/pytest.yaml@main.
git config --global --add init.defaultBranch main git config --global --add advice.detachedHead trueThe hint messages are disabled only for the
test_import_shallowtest. This is because only this test fails underubuntu-latest. Ifwindows-2025ormacos-latestimages are used, all of them fail, as the hints are forced for all the git commands.Since the
codecovaction is only run onubuntu-latest, disabling thetest_import_shallowtest is sufficient.Added the
test_workspaceto the.gitignorefile to safely ignore the dummy folder during test runs.Description of how this change was tested
pytest -s -v test